Token trade plugin added #521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orenyodfat
reviewed
Aug 12, 2020
orenyodfat
reviewed
Aug 12, 2020
orenyodfat
reviewed
Aug 12, 2020
orenyodfat
reviewed
Aug 12, 2020
orenyodfat
reviewed
Aug 12, 2020
orenyodfat
reviewed
Aug 12, 2020
orenyodfat
reviewed
Aug 12, 2020
orenyodfat
suggested changes
Aug 16, 2020
orenyodfat
reviewed
Aug 21, 2020
orenyodfat
reviewed
Aug 21, 2020
orenyodfat
reviewed
Aug 21, 2020
orenyodfat
reviewed
Aug 30, 2020
orenyodfat
reviewed
Aug 30, 2020
orenyodfat
reviewed
Aug 30, 2020
orenyodfat
reviewed
Aug 30, 2020
| @@ -627,6 +628,31 @@ export class Arc extends GraphNodeObserver { | |||
| Logger.debug(`Data saved successfully as ${descriptionHash}`) | |||
| return descriptionHash | |||
| } | |||
|
|
|||
| public approveTokens(tokenAddress: Address, spender: Address, amount: BN) { | |||
There was a problem hiding this comment.
any test which cover that ?
orenyodfat
reviewed
Aug 30, 2020
| const account = '0x90f8bf6a479f320ead074411a4b0e7944ea8c9c1' | ||
| const approval = await arc.approveTokens(tokenAddress, account, new BN(1)).send(); | ||
| expect(approval.transactionHash).toBeDefined(); | ||
| expect(approval.receipt!.status).toEqual(1); |
There was a problem hiding this comment.
how about reading the token here and make sure there is an approval of 1 wei ?
orenyodfat
approved these changes
Aug 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.