add register button #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkent600
force-pushed
the
registerButtonII
branch
from
c0d4cd6
to
f9b1c72
Compare
orenyodfat
reviewed
Jan 8, 2019
| protected wrapper: ExternalLocking4ReputationWrapper; | ||
|
|
||
| private alreadyLocked: boolean; | ||
| private alreadyRegistered: boolean; |
There was a problem hiding this comment.
does the default value is false here ?
How about explicity init that to false?
There was a problem hiding this comment.
with typescript and javascript the default is falsy. But I agree, best to make it explicit; it makes the developer's intent clear.
There was a problem hiding this comment.
fixed here: c1965e3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a Register button to the MGN dashboard, per https://trello.com/c/cxHTH8pc
While the functionality it present, the associated text has not yet been spec'd, therefore for the time being some explanatory text looks wrong.