Added support for custom response exchange #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dapper91
reviewed
Mar 31, 2024
pjrpc/server/integration/aio_pika.py
Outdated
| @@ -40,17 +53,20 @@ def dispatcher(self) -> pjrpc.server.AsyncDispatcher: | |||
|
|
|||
| return self._dispatcher | |||
|
|
|||
| async def start(self, queue_args: Optional[Dict[str, Any]] = None) -> None: | |||
| async def start(self, queue_args: Optional[Dict[str, Any]] = None, exchange_args: Optional[Dict[str, Any]] = None) -> None: | |||
There was a problem hiding this comment.
This line is too long. Please split it to be less than 120 characters.
pjrpc/server/integration/aio_pika.py
Outdated
| ), | ||
| routing_key=reply_to, | ||
| ) | ||
|
|
There was a problem hiding this comment.
Please, remove extra whitespace
pjrpc/server/integration/aio_pika.py
Outdated
| correlation_id=message.correlation_id, | ||
| content_type=pjrpc.common.DEFAULT_CONTENT_TYPE, | ||
| ), | ||
| routing_key=self._tx_routing_key if self._tx_routing_key else reply_to, |
There was a problem hiding this comment.
It seems to be necessary to check that self._tx_routing_key is not None or reply_to is not None otherwise routing_key will be None which is forbidden.
There was a problem hiding this comment.
Correct, thx! Fixed it by using default routing key "" in case neither reply_to or tx_routing_key is given. This could be usesfull on cases where a fanout exchange is used as target.
|
@jgrasboeck Hi, Thanks for your feedback and contribution! |
|
@dapper91 You're very welcome! Anything else I should adjust? |
|
@dapper91 bump |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @dapper91,
First of all, I want to thank you for creating this extensive package!
We are currently adopting your library into our application. As we are using rabbit mq for communication, we use aio_pika as backend.
To integrate the rpc messaging smoothly into the rest of our communication architecture, we would need to be able to specify a custom exchange for the responses plus a custom routing key.
Here's the proposed adjustment of the aio_pika Executor.