.htaccess files Apache 2.4 compatibility update #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The .htaccess files used to restrict access to specific directories follow the Apache 2.2 mod_authz_host module syntax [1] (Order, Allow, Deny). Apache 2.4 introduced a new module mod_authz_core [2], with a different, incompatible directive (Require). Consequently, unless the compatibility module access_compat is enabled, the obsolete ones will cause Apache configuration errors to occur when the .htaccess file is read. To avoid this, the .htaccess files are modified to use the new syntax when an Apache 2.4 server is detected, and fall back to the old directives otherwise. [1] https://httpd.apache.org/docs/2.2/mod/mod_authz_host.html [2] https://httpd.apache.org/docs/2.4/mod/mod_authz_core.html
|
Thanks for spotting that and providing the fix. Looks good, even compatible with Apache 1.3. Merged! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The .htaccess files used to restrict access to specific directories
follow the Apache 2.2 mod_authz_host module syntax [1] (Order, Allow,
Deny).
Apache 2.4 introduced a new module mod_authz_core [2], with a different,
incompatible directive (Require). Consequently, unless the compatibility
module access_compat is enabled, the obsolete ones will cause Apache
configuration errors to occur when the .htaccess file is read.
To avoid this, the .htaccess files are modified to use the new syntax
when an Apache 2.4 server is detected, and fall back to the old
directives otherwise.
[1] https://httpd.apache.org/docs/2.2/mod/mod_authz_host.html
[2] https://httpd.apache.org/docs/2.4/mod/mod_authz_core.html