This repository has been archived by the owner on Jun 13, 2018. It is now read-only.
Prototype of Nix integration and solc picking #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbrock
commented
Sep 8, 2017
| @@ -4,6 +4,28 @@ export DAPP_SRC=${DAPP_SRC-src} | |||
| export DAPP_LIB=${DAPP_LIB-lib} | |||
| export DAPP_OUT=${DAPP_OUT-out} | |||
|
|
|||
| function have() { command -v "$1" >/dev/null 2>&1 ; } | |||
|
|
|||
| for dep in bc curl git node solc ethabi ethrun seth jshon; do | |||
There was a problem hiding this comment.
Demanding ethrun here is stupid since Nix dapp doesn't use ethrun...
This pretty much works fine! I can run dapp in a clean Ubuntu Docker, and it will commence installing Nix, setting up the DappHub Nix channel, and then reinstalling dapp via Nix. It's kind of weird though that you would first download the dapp source code and install it, and then it would immediately reinstall itself in a different place using Nix. So I'm not sure, maybe there should be a separate easy install script, instead of the check in the main dapp program.
|
Wait is this still needed what's going on here hehe |
|
no this is weird crazy stuff |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pretty much works fine! But we shouldn't merge it immediately,
there's some stuff to consider and some stuff to do.
See #53. cc @dbrock
I can run dapp in a clean Ubuntu Docker, and it will commence installing
Nix, setting up the DappHub Nix channel, and then reinstalling dapp
via Nix.
It's kind of weird though that you would first download the dapp source
code and install it, and then it would immediately reinstall itself in a
different place using Nix.
So I'm not sure, maybe there should be a separate easy install script,
instead of the check in the main dapp program.
Until this dapp version is actually in Nix, the
dapp --usewon't work.