Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get pkg ready for holesky testnet #2

Merged
merged 3 commits into from
Nov 2, 2023

Conversation

dappnodedev
Copy link
Contributor

Edit all the configs to switch to Holesky testnet

Copy link
Member

@alexpeterson91 alexpeterson91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please Make sure to use the correct P2P ports when making new clients especially on new networks with many clients. Thanks!

| 8546 | WebSocket | No |
| 8551 | Engine API | No |
| 9545 | Metrics | No |
| 30415 | Peer Traffic | Yes |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to follow the port selection rules laid out dappnode/DAppNode#457 I haven't added Holesky yet but it's chain ID is 17000 (7000, because it's over 5 digits so we only use the last 4). So using the formula the proper P2P port for Besu on Holesky is chain ID + client ID + default port. So 7000 + 11 + 30303 = 37314 for besu Holesky. (Holesky's chain id does create a new exception that actually was introduced with sepolia but it was never actually added to the text of the issue. (It all needs to be written into the developer docs badly so public devs don't just start using outside ports already assigned to other services.) but basically the new exception is that when a chain ID is over 5 digits before multiplying by 10, don't multiply just use the last 4 digits in this case 7000. All other Holesky clients need to make sure their P2P ports are all hardcoded as such just make sure to follow the formula from the issue above. And my example here for Holesky Besu.

Suggested change
| 30415 | Peer Traffic | Yes |
| 37314 | Peer Traffic | Yes |

ports:
- "30414:30414/tcp"
- "30414:30414/udp"
- "30415:30415/tcp"
Copy link
Member

@alexpeterson91 alexpeterson91 Oct 23, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- "30415:30415/tcp"
- "37314:37314/tcp"

- "30414:30414/tcp"
- "30414:30414/udp"
- "30415:30415/tcp"
- "30415:30415/udp"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- "30415:30415/udp"
- "37314:37314/udp"

BESU_SYNC_MODE: X_CHECKPOINT
BESU_RPC_HTTP_MAX_ACTIVE_CONNECTIONS: "170"
BESU_RPC_WS_ENABLED: "true"
P2P_PORT: "30415"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
P2P_PORT: "30415"
P2P_PORT: "37314"

@pablomendezroyo pablomendezroyo merged commit 0810741 into main Nov 2, 2023
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants