Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

port standardization #39

Merged
merged 2 commits into from
Jul 4, 2022
Merged

port standardization #39

merged 2 commits into from
Jul 4, 2022

Conversation

eduadiez
Copy link
Contributor

No description provided.

@tropicar tropicar added this to To do in Packages via automation Jul 1, 2022
@tropicar
Copy link
Contributor

tropicar commented Jul 1, 2022 •
edited
Loading

Info about this PR
According to this issue dappnode/DAppNode#457
We have updated the p2p port:

Adding an env variable with value we have defined in that issue
Add a flag in the dockerfile to change the default port
Add the ports in the docker-compose network configuration

@tropicar tropicar moved this from To do to In progress in Packages Jul 1, 2022
@tropicar tropicar merged commit 0eb4c91 into master Jul 4, 2022
@tropicar tropicar deleted the edu_fix branch July 4, 2022 12:58
Packages automation moved this from In progress to Done Jul 4, 2022
@tropicar tropicar mentioned this pull request Jul 4, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dapplion dapplion Awaiting requested review from dapplion

@pablomendezroyo pablomendezroyo Awaiting requested review from pablomendezroyo

@tropicar tropicar Awaiting requested review from tropicar

Assignees
No one assigned
Labels
None yet
Projects
Packages
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@eduadiez @tropicar