Update dependencies and add CSR subject check. #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3alpha
changed the title
dappnodedev
reviewed
Oct 11, 2023
| @@ -1,4 +1,4 @@ | |||
| FROM node:12-alpine AS node-builder | |||
| FROM node:16-alpine AS node-builder | |||
There was a problem hiding this comment.
Why 16? Wouldn't we want to have a more up-to-date version of node?
There was a problem hiding this comment.
Because that node is available in certbot image we use as final one.
| const csrDomain = await shell(`openssl req -in ${csrPath} -subject -noout | cut -c 31-`); | ||
| if (csrDomain != "dyndns.dappnode.io") { | ||
| rimrafSync(certBaseDir); | ||
| throw new BadRequestError("CSR Subject invalid."); |
There was a problem hiding this comment.
Is this properly caught? Will it cause the app to exit?
There was a problem hiding this comment.
It is caught. You can see that request params were validated in the same way.
| @@ -26,7 +26,7 @@ export async function shell( | |||
| { timeout, maxBuffer } | |||
| ); | |||
| return stdout.trim(); | |||
| } catch (e) { | |||
| } catch (e: any) { | |||
There was a problem hiding this comment.
IDK, compiler was complaining for some reason, that code worked fine before. 😅
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.