Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dapr checks for running dapr_redis container when --redis-host is specified #479

Closed
mukundansundar opened this issue Oct 7, 2020 · 0 comments · Fixed by #488
Closed
Assignees
Labels
kind/bug Something isn't working P1

Comments

@mukundansundar
Copy link
Collaborator

mukundansundar commented Oct 7, 2020

Dapr is still installed in self-hosted mode.

But there is an error printed at the end of init.

Expected Behavior

Dapr init skips checking redis container and not error is printed.

$ dapr init --redis-host testhost
⌛  Making the jump to hyperspace...
←  Downloading binaries and setting up components... You have specified redis-host: testhost. Make sure you have a redis server running there.
→  Downloading binaries and setting up components...
Dapr runtime installed to $HOME/.dapr/bin, you may run the following to add it to your path if you want to run daprd directly:
    export PATH=$PATH:$HOME/.dapr/bin
✅  Downloaded binaries and completed components set up.
ℹ️  daprd binary has been installed to $HOME/.dapr/bin.
ℹ️  dapr_placement container is running.
ℹ️  dapr_zipkin container is running.
ℹ️  Use `docker ps` to check running containers.
✅  Success! Dapr is up and running. To get started, go here: https://aka.ms/dapr-getting-started

Actual Behavior

$ dapr init --redis-host testhost
⌛  Making the jump to hyperspace...
←  Downloading binaries and setting up components... You have specified redis-host: testhost. Make sure you have a redis server running there.
←  Downloading binaries and setting up components...
Dapr runtime installed to $HOME/.dapr/bin, you may run the following to add it to your path if you want to run daprd directly:
    export PATH=$PATH:$HOME/.dapr/bin
✅  Downloaded binaries and completed components set up.
ℹ️  daprd binary has been installed to $HOME/.dapr/bin.
ℹ️  dapr_placement container is running.
❌  container dapr_redis is not running

Steps to Reproduce the Problem

Run dapr init --redis-host testhost

Release Note

RELEASE NOTE: SKIP container check for Redis when --redis-host is specified.

@mukundansundar mukundansundar added kind/bug Something isn't working P1 labels Oct 7, 2020
@mukundansundar mukundansundar added this to To do in 1.0.0 Milestone 1 via automation Oct 7, 2020
@halspang halspang self-assigned this Oct 9, 2020
halspang added a commit to halspang/cli that referenced this issue Oct 9, 2020
When a non-default redis host is specified during init, we do not
try and start the container and assume the user has set it up
correctly. This commit stops an errant error message from dapr
checking if the container is present/running.

dapr#479
@halspang halspang moved this from To do to In progress in 1.0.0 Milestone 1 Oct 12, 2020
1.0.0 Milestone 1 automation moved this from In progress to Review Oct 16, 2020
mukundansundar added a commit that referenced this issue Oct 16, 2020
When a non-default redis host is specified during init, we do not
try and start the container and assume the user has set it up
correctly. This commit stops an errant error message from dapr
checking if the container is present/running.

#479

Co-authored-by: Mukundan Sundararajan <musundar@microsoft.com>
@artursouza artursouza moved this from Review to Done in 1.0.0 Milestone 1 Oct 20, 2020
@artursouza artursouza added this to Release in 1.0.0 Milestone Oct 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working P1
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

2 participants