-
Notifications
You must be signed in to change notification settings - Fork 199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade go version to 1.20 #1246
Conversation
Signed-off-by: letmerecall <girishsharma001@gmail.com>
@letmerecall can you run |
@mukundansundar |
Signed-off-by: letmerecall <girishsharma001@gmail.com>
@mukundansundar There's no apparent error in the logs of Build linux_amd64 binaries job but the runner received a shutdown signal. Should we try to re-run it? |
@letmerecall The linting step is failing in workflow. You should be able to run locally |
Signed-off-by: letmerecall <girishsharma001@gmail.com>
It's strange that I'm not able to run
|
We might need to upgrade golanglint to v1.51.0. Related to this - golangci/golangci-lint#3414 FYI @mukundansundar |
Will create a PR to upgrade linter version. |
will merge #1253 and then update this PR again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@letmerecall
Similar to https://github.com/dapr/dapr/pull/5876/files#diff-aed9855ec5ff916d6ced3a125bd9b76551a22febf05b7e6d4bafd9222eb26dfdR224-R228
Please setup go from the go.mod
file if possible.
with:
go-version-file: 'go.mod'
@letmerecall can you please fix the conflicts |
Signed-off-by: Girish Sharma <girishsharma001@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #1246 +/- ##
=======================================
Coverage 27.35% 27.36%
=======================================
Files 38 38
Lines 3699 3698 -1
=======================================
Hits 1012 1012
+ Misses 2621 2620 -1
Partials 66 66
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Signed-off-by: letmerecall <girishsharma001@gmail.com>
@letmerecall Please checkout the code first and then run go setup action since the change uses go.mod for version value |
Signed-off-by: letmerecall <girishsharma001@gmail.com>
Oops, sorry. I wonder if we have to clear the workflow cache as well? Last time |
@letmerecall I will take a look at this tomorrow morning and will work on fixing and merging this PR. |
Signed-off-by: letmerecall <girishsharma001@gmail.com>
@mukundansundar Cool! my last commit might fix the paths for 'go.mod' in workflow. Feel free to revert otherwise. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm.
@letmerecall Thanks for the contribution !! |
Description
For #1243
To upgrade go version to 1.20.
Issue reference
Please reference the issue this PR will close: #1243
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: