Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix default installation directory permissions #1375

Merged
merged 2 commits into from
Jan 23, 2024

Conversation

twinguy
Copy link
Contributor

@twinguy twinguy commented Jan 19, 2024

Description

Updated default directory permissions to 755 for components and bin directories.

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #1317

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

@twinguy twinguy requested review from a team as code owners January 19, 2024 06:12
Signed-off-by: Kenny Meador <kenny.meador@outlook.com>
Signed-off-by: Kenny Meador <kmeador@dollargeneral.com>
Copy link

codecov bot commented Jan 19, 2024

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (50e1dff) 22.55% compared to head (39a366d) 22.55%.

Files Patch % Lines
pkg/standalone/standalone.go 0.00% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1375   +/-   ##
=======================================
  Coverage   22.55%   22.55%           
=======================================
  Files          40       40           
  Lines        4758     4758           
=======================================
  Hits         1073     1073           
  Misses       3607     3607           
  Partials       78       78           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mukundansundar mukundansundar modified the milestone: v1.13 Jan 23, 2024
@mukundansundar mukundansundar merged commit 2380446 into dapr:master Jan 23, 2024
28 checks passed
@twinguy twinguy deleted the fix-default-dir-permissions branch January 24, 2024 04:11
@yaron2 yaron2 added this to the v1.13 milestone Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unix: Directories in ~/.dapr given 777 permisions.
5 participants