Returns metrics enabled for standalone mode. #529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artursouza
commented
Dec 1, 2020
pkg/standalone/list.go
Outdated
| HTTPPort int `csv:"HTTP PORT"` | ||
| GRPCPort int `csv:"GRPC PORT"` | ||
| AppPort int `csv:"APP PORT"` | ||
| MetricsEnabled bool `csv:"-"` |
There was a problem hiding this comment.
This is on purpose, so it does not pollute the stdout.
There was a problem hiding this comment.
We just need this property in the Dashboard.
There was a problem hiding this comment.
Add this explanation into the code (comment) itself? Thanks
Codecov Report
@@ Coverage Diff @@
## master #529 +/- ##
==========================================
- Coverage 13.91% 13.86% -0.06%
==========================================
Files 27 27
Lines 1272 1277 +5
==========================================
Hits 177 177
- Misses 1065 1070 +5
Partials 30 30
Continue to review full report at Codecov.
|
tcnghia
previously approved these changes
Dec 1, 2020
pkg/standalone/list.go
Outdated
| HTTPPort int `csv:"HTTP PORT"` | ||
| GRPCPort int `csv:"GRPC PORT"` | ||
| AppPort int `csv:"APP PORT"` | ||
| MetricsEnabled bool `csv:"-"` |
There was a problem hiding this comment.
Add this explanation into the code (comment) itself? Thanks
artursouza
force-pushed
the
list_metrics_enabled
branch
from
e8e6aa8
to
46f8f18
Compare
|
Done. Please, approve again. |
mukundansundar
approved these changes
Dec 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Requirement to detect metrics enabled for standalone mode in Dashboard.
Does not output new property.
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: dapr/dashboard#103
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: