Add some negative self-hosted e2e. On error in stop exit with error #683
Conversation
Codecov Report
@@ Coverage Diff @@
## master #683 +/- ##
=======================================
Coverage 19.79% 19.79%
=======================================
Files 28 28
Lines 1364 1364
=======================================
Hits 270 270
Misses 1061 1061
Partials 33 33 Continue to review full report at Codecov.
|
|
|
||
| t.Run("run without install", func(t *testing.T) { | ||
| output, err := spawn.Command(daprPath, "run", "test") | ||
| require.NoError(t, err, "expected no error status on run without install") |
There was a problem hiding this comment.
I think a separate issue has to be created so that we properly exit with error on error from run.
This needs to be separate task since the scenarios for run command are a bit more complex.
| require.Contains(t, output, "Removing Dapr from your machine...", "expected output to contain message") | ||
| path := filepath.Join(homeDir, ".dapr", "bin") | ||
| require.Contains(t, output, "WARNING: "+path+" does not exist", "expected output to contain message") | ||
| require.Contains(t, output, "WARNING: dapr_placement container does not exist", "expected output to contain message") |
There was a problem hiding this comment.
These tests will fail when log message changes. Ideally, those could be a shared constant.
There was a problem hiding this comment.
I mean... changing them later is not hard.
| require.Contains(t, output, "Removing Dapr from your machine...", "expected output to contain message") | ||
| path := filepath.Join(homeDir, ".dapr", "bin") | ||
| require.Contains(t, output, "WARNING: "+path+" does not exist", "expected output to contain message") | ||
| require.Contains(t, output, "WARNING: dapr_placement container does not exist", "expected output to contain message") |
There was a problem hiding this comment.
I mean... changing them later is not hard.
Description
Add some negative self-hosted e2e. On error in stop exit with error
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #[issue number]
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: