runtime: support unix domain socket #788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daixiang0
force-pushed
the
uds
branch
8 times, most recently
from
48a3a00
to
dd73656
Compare
Codecov Report
@@ Coverage Diff @@
## master #788 +/- ##
==========================================
+ Coverage 20.85% 21.82% +0.97%
==========================================
Files 29 29
Lines 1482 1535 +53
==========================================
+ Hits 309 335 +26
- Misses 1136 1159 +23
- Partials 37 41 +4
Continue to review full report at Codecov.
|
daixiang0
force-pushed
the
uds
branch
2 times, most recently
from
291901a
to
8f63990
Compare
|
ping @mkosieradzki @artursouza |
artursouza
reviewed
Aug 30, 2021
daixiang0
force-pushed
the
uds
branch
3 times, most recently
from
d1c71fa
to
a50dc76
Compare
|
@daixiang0 please fix the failing tests. @mukundansundar can you please review? |
|
doc pr: dapr/docs#1730 |
daixiang0
force-pushed
the
uds
branch
9 times, most recently
from
65db46a
to
0457af2
Compare
|
@mukundansundar @yaron2 all tests pass, please review. |
artursouza
requested changes
Oct 13, 2021
|
@msfussell Could you review this PR? |
|
@daixiang0 please update the README with an example for how to use the new parameter. |
daixiang0
force-pushed
the
uds
branch
3 times, most recently
from
11a0c84
to
0ef564b
Compare
|
@yaron2 done. |
Signed-off-by: Long <long.dai@intel.com>
Signed-off-by: Long <long.dai@intel.com>
|
@yaron2 @mukundansundar could we merge it? |
|
Great PR @daixiang0 |
anhldbk
pushed a commit
to anhldbk/dapr-cli
that referenced
this pull request
Dec 22, 2021
* runtime: support unix domain socket Signed-off-by: Long <long.dai@intel.com> * feedback Signed-off-by: Long <long.dai@intel.com> * update example Signed-off-by: Long <long.dai@intel.com>
anhldbk
pushed a commit
to anhldbk/dapr-cli
that referenced
this pull request
Dec 22, 2021
* runtime: support unix domain socket Signed-off-by: Long <long.dai@intel.com> * feedback Signed-off-by: Long <long.dai@intel.com> * update example Signed-off-by: Long <long.dai@intel.com> Signed-off-by: Andy Le <anhldbk@gmail.com>
anhldbk
pushed a commit
to anhldbk/dapr-cli
that referenced
this pull request
Dec 22, 2021
* runtime: support unix domain socket Signed-off-by: Long <long.dai@intel.com> * feedback Signed-off-by: Long <long.dai@intel.com> * update example Signed-off-by: Long <long.dai@intel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Ref dapr/dapr#2864
Since go-sdk still does not support it, no e2e tests added.
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #785
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: