fix shutdown hang when enable socket #835
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mukundansundar please review, also it works when directly use native HTTP client. |
Codecov Report
@@ Coverage Diff @@
## master #835 +/- ##
==========================================
+ Coverage 21.82% 22.36% +0.54%
==========================================
Files 29 29
Lines 1535 1547 +12
==========================================
+ Hits 335 346 +11
- Misses 1159 1160 +1
Partials 41 41
Continue to review full report at Codecov.
|
daixiang0
force-pushed
the
hang
branch
4 times, most recently
from
6ae521f
to
9667ecf
Compare
Signed-off-by: Loong <loong.dai@intel.com>
|
@daixiang0 Please change this line to add back socket test cases Line 42 in standalone_test.go file. |
berndverst
reviewed
Nov 18, 2021
3 tasks
|
@mukundansundar @berndverst done. |
mukundansundar
approved these changes
Nov 22, 2021
11 tasks
|
@dapr/maintainers-cli please review. |
berndverst
pushed a commit
to berndverst/cli
that referenced
this pull request
Nov 29, 2021
* fix shutdown hang when enable socket Signed-off-by: Loong <loong.dai@intel.com> * feedback Signed-off-by: Loong <loong.dai@intel.com> Co-authored-by: Loong <loong.dai@intel.com> Co-authored-by: Mukundan Sundararajan <musundar@microsoft.com>
artursouza
pushed a commit
that referenced
this pull request
Nov 29, 2021
* fix shutdown hang when enable socket Signed-off-by: Loong <loong.dai@intel.com> * feedback Signed-off-by: Loong <loong.dai@intel.com> Co-authored-by: Loong <loong.dai@intel.com> Co-authored-by: Mukundan Sundararajan <musundar@microsoft.com> Co-authored-by: Long Dai <long.dai@intel.com> Co-authored-by: Loong <loong.dai@intel.com> Co-authored-by: Mukundan Sundararajan <musundar@microsoft.com>
anhldbk
pushed a commit
to anhldbk/dapr-cli
that referenced
this pull request
Dec 22, 2021
* fix shutdown hang when enable socket Signed-off-by: Loong <loong.dai@intel.com> * feedback Signed-off-by: Loong <loong.dai@intel.com> Co-authored-by: Loong <loong.dai@intel.com> Co-authored-by: Mukundan Sundararajan <musundar@microsoft.com> Signed-off-by: Andy Le <anhldbk@gmail.com>
anhldbk
pushed a commit
to anhldbk/dapr-cli
that referenced
this pull request
Dec 22, 2021
* fix shutdown hang when enable socket Signed-off-by: Loong <loong.dai@intel.com> * feedback Signed-off-by: Loong <loong.dai@intel.com> Co-authored-by: Loong <loong.dai@intel.com> Co-authored-by: Mukundan Sundararajan <musundar@microsoft.com> Signed-off-by: Andy Le <anhldbk@gmail.com>
anhldbk
pushed a commit
to anhldbk/dapr-cli
that referenced
this pull request
Dec 22, 2021
* fix shutdown hang when enable socket Signed-off-by: Loong <loong.dai@intel.com> * feedback Signed-off-by: Loong <loong.dai@intel.com> Co-authored-by: Loong <loong.dai@intel.com> Co-authored-by: Mukundan Sundararajan <musundar@microsoft.com> Signed-off-by: Andy Le <anhldbk@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Loong loong.dai@intel.com
Description
Go-retryablehttp cannot close idle socket connections, need to call it by hand.
Fix dapr/dapr#3894
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #[issue number]
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: