Skip to content

Commit

Permalink
Change AckDeadline type to time.Duration in GCP Pub/Sub metadata
Browse files Browse the repository at this point in the history
Updated the AckDeadline field in the metadata struct to use time.Duration instead of int. This change allows Dapr to interpret the acknowledgment deadline as either seconds or Go duration strings, providing greater flexibility and usability for configuring message acknowledgment timeouts.
  • Loading branch information
mashley@rechargeapps.com committed May 21, 2024
1 parent dda3674 commit 063057d
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion pubsub/gcp/pubsub/pubsub.go
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ type WhatNow struct {
}

type metadata struct {

Check failure on line 86 in pubsub/gcp/pubsub/pubsub.go

View workflow job for this annotation

GitHub Actions / bindings.cron conformance

metadata redeclared in this block

Check failure on line 86 in pubsub/gcp/pubsub/pubsub.go

View workflow job for this annotation

GitHub Actions / bindings.cron conformance

metadata redeclared in this block

Check failure on line 86 in pubsub/gcp/pubsub/pubsub.go

View workflow job for this annotation

GitHub Actions / crypto.localstorage conformance

metadata redeclared in this block

Check failure on line 86 in pubsub/gcp/pubsub/pubsub.go

View workflow job for this annotation

GitHub Actions / crypto.localstorage conformance

metadata redeclared in this block

Check failure on line 86 in pubsub/gcp/pubsub/pubsub.go

View workflow job for this annotation

GitHub Actions / pubsub.jetstream conformance

metadata redeclared in this block

Check failure on line 86 in pubsub/gcp/pubsub/pubsub.go

View workflow job for this annotation

GitHub Actions / pubsub.jetstream conformance

metadata redeclared in this block

Check failure on line 86 in pubsub/gcp/pubsub/pubsub.go

View workflow job for this annotation

GitHub Actions / bindings.redis.v6 conformance

metadata redeclared in this block

Check failure on line 86 in pubsub/gcp/pubsub/pubsub.go

View workflow job for this annotation

GitHub Actions / bindings.redis.v6 conformance

metadata redeclared in this block

Check failure on line 86 in pubsub/gcp/pubsub/pubsub.go

View workflow job for this annotation

GitHub Actions / lock.redis.v7 conformance

metadata redeclared in this block

Check failure on line 86 in pubsub/gcp/pubsub/pubsub.go

View workflow job for this annotation

GitHub Actions / lock.redis.v7 conformance

metadata redeclared in this block

Check failure on line 86 in pubsub/gcp/pubsub/pubsub.go

View workflow job for this annotation

GitHub Actions / state.in-memory conformance

metadata redeclared in this block

Check failure on line 86 in pubsub/gcp/pubsub/pubsub.go

View workflow job for this annotation

GitHub Actions / state.in-memory conformance

metadata redeclared in this block

Check failure on line 86 in pubsub/gcp/pubsub/pubsub.go

View workflow job for this annotation

GitHub Actions / secretstores.hashicorp.vault conformance

metadata redeclared in this block

Check failure on line 86 in pubsub/gcp/pubsub/pubsub.go

View workflow job for this annotation

GitHub Actions / secretstores.hashicorp.vault conformance

metadata redeclared in this block

Check failure on line 86 in pubsub/gcp/pubsub/pubsub.go

View workflow job for this annotation

GitHub Actions / configuration.redis.v6 conformance

metadata redeclared in this block

Check failure on line 86 in pubsub/gcp/pubsub/pubsub.go

View workflow job for this annotation

GitHub Actions / configuration.redis.v6 conformance

metadata redeclared in this block

Check failure on line 86 in pubsub/gcp/pubsub/pubsub.go

View workflow job for this annotation

GitHub Actions / bindings.http conformance

metadata redeclared in this block

Check failure on line 86 in pubsub/gcp/pubsub/pubsub.go

View workflow job for this annotation

GitHub Actions / bindings.http conformance

metadata redeclared in this block

Check failure on line 86 in pubsub/gcp/pubsub/pubsub.go

View workflow job for this annotation

GitHub Actions / state.sqlite conformance

metadata redeclared in this block

Check failure on line 86 in pubsub/gcp/pubsub/pubsub.go

View workflow job for this annotation

GitHub Actions / state.sqlite conformance

metadata redeclared in this block

Check failure on line 86 in pubsub/gcp/pubsub/pubsub.go

View workflow job for this annotation

GitHub Actions / state.postgresql.v2.docker conformance

metadata redeclared in this block

Check failure on line 86 in pubsub/gcp/pubsub/pubsub.go

View workflow job for this annotation

GitHub Actions / state.postgresql.v2.docker conformance

metadata redeclared in this block

Check failure on line 86 in pubsub/gcp/pubsub/pubsub.go

View workflow job for this annotation

GitHub Actions / pubsub.redis.v6 conformance

metadata redeclared in this block

Check failure on line 86 in pubsub/gcp/pubsub/pubsub.go

View workflow job for this annotation

GitHub Actions / pubsub.redis.v6 conformance

metadata redeclared in this block

Check failure on line 86 in pubsub/gcp/pubsub/pubsub.go

View workflow job for this annotation

GitHub Actions / state.redis.v7 conformance

metadata redeclared in this block

Check failure on line 86 in pubsub/gcp/pubsub/pubsub.go

View workflow job for this annotation

GitHub Actions / state.redis.v7 conformance

metadata redeclared in this block

Check failure on line 86 in pubsub/gcp/pubsub/pubsub.go

View workflow job for this annotation

GitHub Actions / state.rethinkdb conformance

metadata redeclared in this block

Check failure on line 86 in pubsub/gcp/pubsub/pubsub.go

View workflow job for this annotation

GitHub Actions / state.rethinkdb conformance

metadata redeclared in this block

Check failure on line 86 in pubsub/gcp/pubsub/pubsub.go

View workflow job for this annotation

GitHub Actions / pubsub.rabbitmq conformance

metadata redeclared in this block

Check failure on line 86 in pubsub/gcp/pubsub/pubsub.go

View workflow job for this annotation

GitHub Actions / pubsub.rabbitmq conformance

metadata redeclared in this block

Check failure on line 86 in pubsub/gcp/pubsub/pubsub.go

View workflow job for this annotation

GitHub Actions / pubsub.kubemq conformance

metadata redeclared in this block

Check failure on line 86 in pubsub/gcp/pubsub/pubsub.go

View workflow job for this annotation

GitHub Actions / pubsub.kubemq conformance

metadata redeclared in this block

Check failure on line 86 in pubsub/gcp/pubsub/pubsub.go

View workflow job for this annotation

GitHub Actions / bindings.mqtt3-mosquitto conformance

metadata redeclared in this block

Check failure on line 86 in pubsub/gcp/pubsub/pubsub.go

View workflow job for this annotation

GitHub Actions / bindings.mqtt3-mosquitto conformance

metadata redeclared in this block

Check failure on line 86 in pubsub/gcp/pubsub/pubsub.go

View workflow job for this annotation

GitHub Actions / state.etcd.v2 conformance

metadata redeclared in this block

Check failure on line 86 in pubsub/gcp/pubsub/pubsub.go

View workflow job for this annotation

GitHub Actions / state.etcd.v2 conformance

metadata redeclared in this block

Check failure on line 86 in pubsub/gcp/pubsub/pubsub.go

View workflow job for this annotation

GitHub Actions / state.redis.v6 conformance

metadata redeclared in this block

Check failure on line 86 in pubsub/gcp/pubsub/pubsub.go

View workflow job for this annotation

GitHub Actions / state.redis.v6 conformance

metadata redeclared in this block

Check failure on line 86 in pubsub/gcp/pubsub/pubsub.go

View workflow job for this annotation

GitHub Actions / bindings.redis.v7 conformance

metadata redeclared in this block

Check failure on line 86 in pubsub/gcp/pubsub/pubsub.go

View workflow job for this annotation

GitHub Actions / bindings.redis.v7 conformance

metadata redeclared in this block

Check failure on line 86 in pubsub/gcp/pubsub/pubsub.go

View workflow job for this annotation

GitHub Actions / bindings.influx conformance

metadata redeclared in this block

Check failure on line 86 in pubsub/gcp/pubsub/pubsub.go

View workflow job for this annotation

GitHub Actions / bindings.influx conformance

metadata redeclared in this block

Check failure on line 86 in pubsub/gcp/pubsub/pubsub.go

View workflow job for this annotation

GitHub Actions / bindings.postgresql.docker conformance

metadata redeclared in this block

Check failure on line 86 in pubsub/gcp/pubsub/pubsub.go

View workflow job for this annotation

GitHub Actions / bindings.postgresql.docker conformance

metadata redeclared in this block

Check failure on line 86 in pubsub/gcp/pubsub/pubsub.go

View workflow job for this annotation

GitHub Actions / state.mysql.mariadb conformance

metadata redeclared in this block

Check failure on line 86 in pubsub/gcp/pubsub/pubsub.go

View workflow job for this annotation

GitHub Actions / state.mysql.mariadb conformance

metadata redeclared in this block

Check failure on line 86 in pubsub/gcp/pubsub/pubsub.go

View workflow job for this annotation

GitHub Actions / configuration.redis.v7 conformance

metadata redeclared in this block

Check failure on line 86 in pubsub/gcp/pubsub/pubsub.go

View workflow job for this annotation

GitHub Actions / configuration.redis.v7 conformance

metadata redeclared in this block

Check failure on line 86 in pubsub/gcp/pubsub/pubsub.go

View workflow job for this annotation

GitHub Actions / configuration.postgresql.docker conformance

metadata redeclared in this block

Check failure on line 86 in pubsub/gcp/pubsub/pubsub.go

View workflow job for this annotation

GitHub Actions / configuration.postgresql.docker conformance

metadata redeclared in this block

Check failure on line 86 in pubsub/gcp/pubsub/pubsub.go

View workflow job for this annotation

GitHub Actions / pubsub.mqtt3-vernemq conformance

metadata redeclared in this block

Check failure on line 86 in pubsub/gcp/pubsub/pubsub.go

View workflow job for this annotation

GitHub Actions / bindings.mqtt3-vernemq conformance

metadata redeclared in this block

Check failure on line 86 in pubsub/gcp/pubsub/pubsub.go

View workflow job for this annotation

GitHub Actions / pubsub.mqtt3-vernemq conformance

metadata redeclared in this block

Check failure on line 86 in pubsub/gcp/pubsub/pubsub.go

View workflow job for this annotation

GitHub Actions / bindings.mqtt3-vernemq conformance

metadata redeclared in this block

Check failure on line 86 in pubsub/gcp/pubsub/pubsub.go

View workflow job for this annotation

GitHub Actions / state.postgresql.v1.docker conformance

metadata redeclared in this block

Check failure on line 86 in pubsub/gcp/pubsub/pubsub.go

View workflow job for this annotation

GitHub Actions / state.postgresql.v1.docker conformance

metadata redeclared in this block

Check failure on line 86 in pubsub/gcp/pubsub/pubsub.go

View workflow job for this annotation

GitHub Actions / secretstores.local.env conformance

metadata redeclared in this block

Check failure on line 86 in pubsub/gcp/pubsub/pubsub.go

View workflow job for this annotation

GitHub Actions / secretstores.local.env conformance

metadata redeclared in this block

Check failure on line 86 in pubsub/gcp/pubsub/pubsub.go

View workflow job for this annotation

GitHub Actions / state.memcached conformance

metadata redeclared in this block

Check failure on line 86 in pubsub/gcp/pubsub/pubsub.go

View workflow job for this annotation

GitHub Actions / state.memcached conformance

metadata redeclared in this block

Check failure on line 86 in pubsub/gcp/pubsub/pubsub.go

View workflow job for this annotation

GitHub Actions / crypto.jwks conformance

metadata redeclared in this block

Check failure on line 86 in pubsub/gcp/pubsub/pubsub.go

View workflow job for this annotation

GitHub Actions / crypto.jwks conformance

metadata redeclared in this block

Check failure on line 86 in pubsub/gcp/pubsub/pubsub.go

View workflow job for this annotation

GitHub Actions / pubsub.in-memory conformance

metadata redeclared in this block

Check failure on line 86 in pubsub/gcp/pubsub/pubsub.go

View workflow job for this annotation

GitHub Actions / pubsub.in-memory conformance

metadata redeclared in this block

Check failure on line 86 in pubsub/gcp/pubsub/pubsub.go

View workflow job for this annotation

GitHub Actions / bindings.kubemq conformance

metadata redeclared in this block

Check failure on line 86 in pubsub/gcp/pubsub/pubsub.go

View workflow job for this annotation

GitHub Actions / bindings.kubemq conformance

metadata redeclared in this block

Check failure on line 86 in pubsub/gcp/pubsub/pubsub.go

View workflow job for this annotation

GitHub Actions / pubsub.mqtt3-emqx conformance

metadata redeclared in this block

Check failure on line 86 in pubsub/gcp/pubsub/pubsub.go

View workflow job for this annotation

GitHub Actions / pubsub.mqtt3-emqx conformance

metadata redeclared in this block

Check failure on line 86 in pubsub/gcp/pubsub/pubsub.go

View workflow job for this annotation

GitHub Actions / pubsub.solace conformance

metadata redeclared in this block

Check failure on line 86 in pubsub/gcp/pubsub/pubsub.go

View workflow job for this annotation

GitHub Actions / pubsub.solace conformance

metadata redeclared in this block

Check failure on line 86 in pubsub/gcp/pubsub/pubsub.go

View workflow job for this annotation

GitHub Actions / state.mysql.mysql conformance

metadata redeclared in this block

Check failure on line 86 in pubsub/gcp/pubsub/pubsub.go

View workflow job for this annotation

GitHub Actions / state.mysql.mysql conformance

metadata redeclared in this block

Check failure on line 86 in pubsub/gcp/pubsub/pubsub.go

View workflow job for this annotation

GitHub Actions / state.cassandra conformance

metadata redeclared in this block

Check failure on line 86 in pubsub/gcp/pubsub/pubsub.go

View workflow job for this annotation

GitHub Actions / state.cassandra conformance

metadata redeclared in this block

Check failure on line 86 in pubsub/gcp/pubsub/pubsub.go

View workflow job for this annotation

GitHub Actions / state.oracledatabase conformance

metadata redeclared in this block

Check failure on line 86 in pubsub/gcp/pubsub/pubsub.go

View workflow job for this annotation

GitHub Actions / state.oracledatabase conformance

metadata redeclared in this block

Check failure on line 86 in pubsub/gcp/pubsub/pubsub.go

View workflow job for this annotation

GitHub Actions / bindings.rabbitmq conformance

metadata redeclared in this block

Check failure on line 86 in pubsub/gcp/pubsub/pubsub.go

View workflow job for this annotation

GitHub Actions / bindings.rabbitmq conformance

metadata redeclared in this block

Check failure on line 86 in pubsub/gcp/pubsub/pubsub.go

View workflow job for this annotation

GitHub Actions / state.etcd.v1 conformance

metadata redeclared in this block

Check failure on line 86 in pubsub/gcp/pubsub/pubsub.go

View workflow job for this annotation

GitHub Actions / state.etcd.v1 conformance

metadata redeclared in this block

Check failure on line 86 in pubsub/gcp/pubsub/pubsub.go

View workflow job for this annotation

GitHub Actions / pubsub.kafka-confluent conformance

metadata redeclared in this block

Check failure on line 86 in pubsub/gcp/pubsub/pubsub.go

View workflow job for this annotation

GitHub Actions / pubsub.kafka-confluent conformance

metadata redeclared in this block

Check failure on line 86 in pubsub/gcp/pubsub/pubsub.go

View workflow job for this annotation

GitHub Actions / state.mongodb conformance

metadata redeclared in this block

Check failure on line 86 in pubsub/gcp/pubsub/pubsub.go

View workflow job for this annotation

GitHub Actions / state.mongodb conformance

metadata redeclared in this block

Check failure on line 86 in pubsub/gcp/pubsub/pubsub.go

View workflow job for this annotation

GitHub Actions / bindings.kafka-wurstmeister conformance

metadata redeclared in this block

Check failure on line 86 in pubsub/gcp/pubsub/pubsub.go

View workflow job for this annotation

GitHub Actions / bindings.kafka-wurstmeister conformance

metadata redeclared in this block

Check failure on line 86 in pubsub/gcp/pubsub/pubsub.go

View workflow job for this annotation

GitHub Actions / lock.redis.v6 conformance

metadata redeclared in this block

Check failure on line 86 in pubsub/gcp/pubsub/pubsub.go

View workflow job for this annotation

GitHub Actions / lock.redis.v6 conformance

metadata redeclared in this block

Check failure on line 86 in pubsub/gcp/pubsub/pubsub.go

View workflow job for this annotation

GitHub Actions / bindings.mqtt3-emqx conformance

metadata redeclared in this block

Check failure on line 86 in pubsub/gcp/pubsub/pubsub.go

View workflow job for this annotation

GitHub Actions / bindings.mqtt3-emqx conformance

metadata redeclared in this block

Check failure on line 86 in pubsub/gcp/pubsub/pubsub.go

View workflow job for this annotation

GitHub Actions / state.cockroachdb.v1 conformance

metadata redeclared in this block

Check failure on line 86 in pubsub/gcp/pubsub/pubsub.go

View workflow job for this annotation

GitHub Actions / state.cockroachdb.v1 conformance

metadata redeclared in this block

Check failure on line 86 in pubsub/gcp/pubsub/pubsub.go

View workflow job for this annotation

GitHub Actions / pubsub.pulsar conformance

metadata redeclared in this block

Check failure on line 86 in pubsub/gcp/pubsub/pubsub.go

View workflow job for this annotation

GitHub Actions / pubsub.pulsar conformance

metadata redeclared in this block

Check failure on line 86 in pubsub/gcp/pubsub/pubsub.go

View workflow job for this annotation

GitHub Actions / secretstores.kubernetes conformance

metadata redeclared in this block

Check failure on line 86 in pubsub/gcp/pubsub/pubsub.go

View workflow job for this annotation

GitHub Actions / secretstores.kubernetes conformance

metadata redeclared in this block

Check failure on line 86 in pubsub/gcp/pubsub/pubsub.go

View workflow job for this annotation

GitHub Actions / pubsub.kafka-wurstmeister conformance

metadata redeclared in this block

Check failure on line 86 in pubsub/gcp/pubsub/pubsub.go

View workflow job for this annotation

GitHub Actions / pubsub.kafka-wurstmeister conformance

metadata redeclared in this block

Check failure on line 86 in pubsub/gcp/pubsub/pubsub.go

View workflow job for this annotation

GitHub Actions / bindings.kafka-confluent conformance

metadata redeclared in this block

Check failure on line 86 in pubsub/gcp/pubsub/pubsub.go

View workflow job for this annotation

GitHub Actions / bindings.kafka-confluent conformance

metadata redeclared in this block

Check failure on line 86 in pubsub/gcp/pubsub/pubsub.go

View workflow job for this annotation

GitHub Actions / secretstores.local.file conformance

metadata redeclared in this block

Check failure on line 86 in pubsub/gcp/pubsub/pubsub.go

View workflow job for this annotation

GitHub Actions / secretstores.local.file conformance

metadata redeclared in this block
AckDeadline int `mapstructure:"ackDeadline"`
AckDeadline time.Duration `mapstructure:"ackDeadline"`
}

const topicCacheRefreshInterval = 5 * time.Hour
Expand Down

0 comments on commit 063057d

Please sign in to comment.