Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conformance test for bindings list operation does not invoke ListOperation #1051

Closed
CodeMonkeyLeet opened this issue Aug 3, 2021 · 4 comments
Labels
kind/bug Something isn't working pinned Issue does not get stale

Comments

@CodeMonkeyLeet
Copy link
Contributor

CodeMonkeyLeet commented Aug 3, 2021

Expected Behavior

Bindings tests that specify the list operation should invoke the List operation.

Actual Behavior

The list operation ends up invoking the Get operation on line 195:

// ListOperation
if config.HasOperation(string(bindings.ListOperation)) {
t.Run("list", func(t *testing.T) {
req := config.createInvokeRequest()
req.Operation = bindings.GetOperation
_, err := outputBinding.Invoke(&req)
assert.NoError(t, err, "expected no error invoking output binding")
})
}

Making the one line code fix causes the only test to use the list operation to fail (azure.blobstorage) with:

=== RUN   TestBindingsConformance/azure.blobstorage/list
    bindings.go:199: 
        	Error Trace:	bindings.go:199
        	Error:      	Received unexpected error:
        	            	json: cannot unmarshal array into Go value of type blobstorage.listPayload
        	Test:       	TestBindingsConformance/azure.blobstorage/list
        	Messages:   	expected no error invoking output binding

Steps to Reproduce the Problem

Code inspection, run conformance tests using the conformance.yml workflow or manual instructions

Release Note

Test fix, should not require a release note.

@dapr-bot
Copy link
Collaborator

dapr-bot commented Sep 2, 2021

This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in the next 7 days unless it is tagged (pinned, good first issue, help wanted or triaged/resolved) or other activity occurs. Thank you for your contributions.

@dapr-bot dapr-bot added the stale label Sep 2, 2021
@dapr-bot
Copy link
Collaborator

dapr-bot commented Sep 9, 2021

This issue has been automatically closed because it has not had activity in the last 37 days. If this issue is still valid, please ping a maintainer and ask them to label it as pinned, good first issue, help wanted or triaged/resolved. Thank you for your contributions.

@CodeMonkeyLeet
Copy link
Contributor Author

Bug remains active pending a fix.

@dapr-bot dapr-bot removed the stale label Sep 9, 2021
@artursouza artursouza added the pinned Issue does not get stale label Sep 9, 2021
@rainfd
Copy link
Contributor

rainfd commented Nov 24, 2021

already fix in #1317

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working pinned Issue does not get stale
Projects
None yet
Development

No branches or pull requests

5 participants