Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need to replace deprecated golang/protobuf/ptypes package #1261

Closed
taoj-action opened this issue Nov 1, 2021 · 2 comments · Fixed by #1303
Closed

Need to replace deprecated golang/protobuf/ptypes package #1261

taoj-action opened this issue Nov 1, 2021 · 2 comments · Fixed by #1303
Labels
kind/bug Something isn't working

Comments

@taoj-action
Copy link
Contributor

Expected Behavior

The build should pass ci-lint.

Actual Behavior

Some components use deprecated packages and cause a build failure. See #1257

Steps to Reproduce the Problem

$ grep -r ptype .
./state/cloudstate/proto/kv_store/kv_store.pb.go:	any "github.com/golang/protobuf/ptypes/any"
./state/cloudstate/proto/kv_store/kv_store.pb.go:	empty "github.com/golang/protobuf/ptypes/empty"
./state/cloudstate/proto/entity.pb.go:	any "github.com/golang/protobuf/ptypes/any"
./state/cloudstate/proto/entity.pb.go:	empty "github.com/golang/protobuf/ptypes/empty"
./state/cloudstate/proto/crdt.pb.go:	any "github.com/golang/protobuf/ptypes/any"
./state/cloudstate/cloudstate_crdt.go:	"github.com/golang/protobuf/ptypes"
./state/cloudstate/cloudstate_crdt.go:	any "github.com/golang/protobuf/ptypes/any"
./state/cloudstate/cloudstate_crdt.go:	empty "github.com/golang/protobuf/ptypes/empty"
./state/cloudstate/cloudstate_crdt.go:				a, _ := ptypes.MarshalAny(&resp)
./state/cloudstate/cloudstate_crdt.go:				a, _ := ptypes.MarshalAny(&e)
./state/cloudstate/cloudstate_crdt.go:				a, _ := ptypes.MarshalAny(&e)
./state/cloudstate/cloudstate_crdt.go:					err := ptypes.UnmarshalAny(vAny, &saveState)

It uses ptypes package and it is marked as deprecated which causes ci-lint error.
https://pkg.go.dev/github.com/golang/protobuf/ptypes

Release Note

RELEASE NOTE:

@taoj-action taoj-action added the kind/bug Something isn't working label Nov 1, 2021
@daixiang0
Copy link
Member

Are you interested in fixing it?

@CodeMonkeyLeet
Copy link
Contributor

This will be addressed by removing the component. See #1297

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working
Projects
None yet
3 participants