Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Cloudstate state store #1303

Merged
merged 3 commits into from Nov 18, 2021
Merged

Remove Cloudstate state store #1303

merged 3 commits into from Nov 18, 2021

Conversation

CodeMonkeyLeet
Copy link
Contributor

@CodeMonkeyLeet CodeMonkeyLeet commented Nov 13, 2021 •
edited

Description

Remove the Cloudstate state store.

⚠ Requires dapr/dapr#3897

Issue reference

Resolves #1297
Resolves #1261

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

Remove Cloudstate component
8981a2f 
- Remove cloudstate state store component
- Update state/Readme.md

Fixes dapr#1297
@CodeMonkeyLeet CodeMonkeyLeet requested review from a team as code owners November 13, 2021 00:30
@CodeMonkeyLeet CodeMonkeyLeet mentioned this pull request Nov 13, 2021
Closed
2 tasks
@codecov
Copy link

codecov bot commented Nov 17, 2021

Codecov Report

Merging #1303 (f607fc1) into master (09fb60c) will increase coverage by 0.29%.
The diff coverage is 27.85%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1303      +/-   ##
==========================================
+ Coverage   35.02%   35.32%   +0.29%     
==========================================
  Files         148      147       -1     
  Lines       12825    12657     -168     
==========================================
- Hits         4492     4471      -21     
+ Misses       7853     7703     -150     
- Partials      480      483       +3
Impacted Files Coverage Δ
bindings/azure/eventgrid/eventgrid.go 3.84% <0.00%> (ø)
authentication/azure/auth.go 40.82% <2.04%> (-15.27%) ⬇️
secretstores/azure/keyvault/keyvault.go 36.25% <33.33%> (+2.00%) ⬆️
pubsub/rabbitmq/rabbitmq.go 57.14% <46.03%> (-7.15%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3eafb8b...f607fc1. Read the comment docs.

mukundansundar
mukundansundar approved these changes Nov 18, 2021
View reviewed changes
Copy link
Contributor

@mukundansundar mukundansundar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@artursouza artursouza merged commit dfe52cf into dapr:master Nov 18, 2021
@artursouza artursouza added this to the v1.6 milestone Nov 18, 2021
sthussey pushed a commit to sthussey/components-contrib that referenced this pull request Dec 8, 2021
@CodeMonkeyLeet @daixiang0 @sthussey
Remove Cloudstate component (dapr#1303)
7f1cbc6 
- Remove cloudstate state store component
- Update state/Readme.md

Fixes dapr#1297

Co-authored-by: Long Dai <long.dai@intel.com>
Signed-off-by: Scott Hussey <sthussey@gmail.com>
amimimor pushed a commit to amimimor/components-contrib that referenced this pull request Dec 9, 2021
@CodeMonkeyLeet @daixiang0 @amimimor
Remove Cloudstate component (dapr#1303)
b8a7baa 
- Remove cloudstate state store component
- Update state/Readme.md

Fixes dapr#1297

Co-authored-by: Long Dai <long.dai@intel.com>
Signed-off-by: Amit Mor <amitm@at-bay.com>
amimimor pushed a commit to amimimor/components-contrib that referenced this pull request Dec 9, 2021
@CodeMonkeyLeet @daixiang0 @amimimor
Remove Cloudstate component (dapr#1303)
6a06818 
- Remove cloudstate state store component
- Update state/Readme.md

Fixes dapr#1297

Co-authored-by: Long Dai <long.dai@intel.com>
Signed-off-by: Amit Mor <amitm@at-bay.com>
amimimor pushed a commit to amimimor/components-contrib that referenced this pull request Dec 9, 2021
@CodeMonkeyLeet @daixiang0 @amimimor
Remove Cloudstate component (dapr#1303)
9bf3fe4 
- Remove cloudstate state store component
- Update state/Readme.md

Fixes dapr#1297

Co-authored-by: Long Dai <long.dai@intel.com>
Signed-off-by: Amit Mor <amitm@at-bay.com>
amimimor pushed a commit to amimimor/components-contrib that referenced this pull request Dec 9, 2021
@CodeMonkeyLeet @daixiang0 @amimimor
Remove Cloudstate component (dapr#1303)
5645c17 
- Remove cloudstate state store component
- Update state/Readme.md

Fixes dapr#1297

Co-authored-by: Long Dai <long.dai@intel.com>
Signed-off-by: Amit Mor <amitm@at-bay.com>
amimimor pushed a commit to amimimor/components-contrib that referenced this pull request Dec 9, 2021
@CodeMonkeyLeet @daixiang0 @amimimor
Remove Cloudstate component (dapr#1303)
c9e05f5 
- Remove cloudstate state store component
- Update state/Readme.md

Fixes dapr#1297

Co-authored-by: Long Dai <long.dai@intel.com>
Signed-off-by: Amit Mor <amitm@at-bay.com>
amimimor pushed a commit to amimimor/components-contrib that referenced this pull request Dec 9, 2021
@CodeMonkeyLeet @daixiang0
Remove Cloudstate component (dapr#1303)
65a2a85 
- Remove cloudstate state store component
- Update state/Readme.md

Fixes dapr#1297

Co-authored-by: Long Dai <long.dai@intel.com>
amimimor pushed a commit to amimimor/components-contrib that referenced this pull request Dec 10, 2021
@CodeMonkeyLeet @daixiang0 @amimimor
Remove Cloudstate component (dapr#1303)
5c9de34 
- Remove cloudstate state store component
- Update state/Readme.md

Fixes dapr#1297

Co-authored-by: Long Dai <long.dai@intel.com>
Signed-off-by: Amit Mor <amit.mor@hotmail.com>
amimimor pushed a commit to amimimor/components-contrib that referenced this pull request Dec 10, 2021
@CodeMonkeyLeet @daixiang0 @amimimor
Remove Cloudstate component (dapr#1303)
90e3c3f 
- Remove cloudstate state store component
- Update state/Readme.md

Fixes dapr#1297

Co-authored-by: Long Dai <long.dai@intel.com>
Signed-off-by: Amit Mor <amit.mor@hotmail.com>
jigargandhi pushed a commit to jigargandhi/components-contrib that referenced this pull request Dec 12, 2021
@CodeMonkeyLeet @daixiang0 @jigargandhi
Remove Cloudstate component (dapr#1303)
039b6d4 
- Remove cloudstate state store component
- Update state/Readme.md

Fixes dapr#1297

Co-authored-by: Long Dai <long.dai@intel.com>
Signed-off-by: jigargandhi <jigarr.gandhi@gmail.com>
beiwei30 pushed a commit to beiwei30/components-contrib that referenced this pull request Dec 14, 2021
@CodeMonkeyLeet @daixiang0 @beiwei30
Remove Cloudstate component (dapr#1303)
cb3d241 
- Remove cloudstate state store component
- Update state/Readme.md

Fixes dapr#1297

Co-authored-by: Long Dai <long.dai@intel.com>
Signed-off-by: Ian Luo <ian.luo@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@artursouza artursouza artursouza approved these changes

@mukundansundar mukundansundar mukundansundar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.6
Development

Successfully merging this pull request may close these issues.

Remove Cloud state component Need to replace deprecated golang/protobuf/ptypes package
4 participants
@CodeMonkeyLeet @artursouza @mukundansundar @daixiang0