Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Azure EventHubs binding: Remove "close by interrupt signal" logic #894

Closed
pkedy opened this issue May 27, 2021 · 2 comments
Closed

Azure EventHubs binding: Remove "close by interrupt signal" logic #894

pkedy opened this issue May 27, 2021 · 2 comments
Assignees
Labels

Comments

@pkedy
Copy link
Member

pkedy commented May 27, 2021

Expected Behavior

This component has a client to cleanup. The Dapr runtime now calls Close() error on any component that implements io.Closer. Logic to cleanup should be moved there.

Actual Behavior

Currently it uses a signal channel to wait to close itself.

RELEASE NOTE: FIX Azure EventHubs binding implements Close() for cleanup

@pkedy pkedy added kind/bug Something isn't working good first issue Good for newcomers labels May 27, 2021
@CodeMonkeyLeet
Copy link
Contributor

/assign

@CodeMonkeyLeet
Copy link
Contributor

Closing this issue as the addition and the move of logic into Close() error is handled by #1093.

Using dapr/dapr#3555 to track the broader question of replacing wait on SIGTERM with appropriate cancellation contexts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants