Restored backwards compatibility with 1.3 #1131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dapr#972 accidentally introduced a backwards-incompatible change with a feature added in 1.3. Before, it was possible to specify an Azure environment for the AKV secret store by passing a FQDN as "vaultName" property that included the suffix for the Azure environment. dapr#972 introduced a better way to handle this (using the "azureEnvironment" metadata property), but accidentally broke the behavior added in 1.3 This patch restores full compatibility with 1.3. Although that behavior should be considered deprecated and thus discouraged (and it will be removed from docs), it will still be supported.
ItalyPaleAle
commented
Sep 10, 2021
| // This should be considered deprecated and users should rely the "azureEnvironment" metadata instead, but it's maintained here for backwards-compatibility | ||
| if vaultName, ok := metadata.Properties[componentVaultName]; ok { | ||
| keyVaultSuffixToEnvironment := map[string]string{ | ||
| ".vault.azure.net": "AZUREPUBLICCLOUD", |
There was a problem hiding this comment.
Note that the list of suffixes is hardcoded here because it was in 1.3. This will support any (and all) the ones that were supported by 1.3
yaron2
previously approved these changes
Sep 10, 2021
artursouza
previously approved these changes
Sep 10, 2021
|
@ItalyPaleAle there's a small lint issue |
ItalyPaleAle
dismissed stale reviews from artursouza and yaron2
via
6cc5d52
Codecov Report
@@ Coverage Diff @@
## master #1131 +/- ##
==========================================
- Coverage 34.53% 33.72% -0.81%
==========================================
Files 132 138 +6
Lines 10870 11629 +759
==========================================
+ Hits 3754 3922 +168
- Misses 6736 7304 +568
- Partials 380 403 +23
Continue to review full report at Codecov.
|
yaron2
approved these changes
Sep 10, 2021
artursouza
pushed a commit
to artursouza/components-contrib
that referenced
this pull request
Sep 10, 2021
* Restored backwards compatibility with 1.3 dapr#972 accidentally introduced a backwards-incompatible change with a feature added in 1.3. Before, it was possible to specify an Azure environment for the AKV secret store by passing a FQDN as "vaultName" property that included the suffix for the Azure environment. dapr#972 introduced a better way to handle this (using the "azureEnvironment" metadata property), but accidentally broke the behavior added in 1.3 This patch restores full compatibility with 1.3. Although that behavior should be considered deprecated and thus discouraged (and it will be removed from docs), it will still be supported. * Lint
3 tasks
artursouza
added a commit
that referenced
this pull request
Sep 10, 2021
* Restored backwards compatibility with 1.3 #972 accidentally introduced a backwards-incompatible change with a feature added in 1.3. Before, it was possible to specify an Azure environment for the AKV secret store by passing a FQDN as "vaultName" property that included the suffix for the Azure environment. #972 introduced a better way to handle this (using the "azureEnvironment" metadata property), but accidentally broke the behavior added in 1.3 This patch restores full compatibility with 1.3. Although that behavior should be considered deprecated and thus discouraged (and it will be removed from docs), it will still be supported. * Lint Co-authored-by: Alessandro (Ale) Segala <43508+ItalyPaleAle@users.noreply.github.com>
amimimor
pushed a commit
to amimimor/components-contrib
that referenced
this pull request
Dec 9, 2021
* Restored backwards compatibility with 1.3 dapr#972 accidentally introduced a backwards-incompatible change with a feature added in 1.3. Before, it was possible to specify an Azure environment for the AKV secret store by passing a FQDN as "vaultName" property that included the suffix for the Azure environment. dapr#972 introduced a better way to handle this (using the "azureEnvironment" metadata property), but accidentally broke the behavior added in 1.3 This patch restores full compatibility with 1.3. Although that behavior should be considered deprecated and thus discouraged (and it will be removed from docs), it will still be supported. * Lint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#972 accidentally introduced a backwards-incompatible change with a feature added in 1.3. Before, it was possible to specify an Azure environment for the AKV secret store by passing a FQDN as "vaultName" property that included the suffix for the Azure environment.
#972 introduced a better way to handle this (using the "azureEnvironment" metadata property), but accidentally broke the behavior added in 1.3
This patch restores full compatibility with 1.3. Although that behavior should be considered deprecated and thus discouraged (and it will be removed from docs), it will still be supported.
This should be considered a hotfix for the upcoming 1.4
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: