go mod tidy issue in tests/certification #1319

[beiwei30]

Description

exclude "github.com/prometheus/common" in tests/certification/go.mod to make go mod tidy pass.

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #1319

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

• Code compiles correctly
• Created/updated tests
• Extended the documentation / Created issue in the https://github.com/dapr/docs/ repo: dapr/docs#[issue number]

[codecov]

Codecov Report

Merging #1320 (20fe589) into master (09fb60c) will increase coverage by 0.27%.
The diff coverage is 24.84%.

@@            Coverage Diff             @@
##           master    #1320      +/-   ##
==========================================
+ Coverage   35.02%   35.29%   +0.27%     
==========================================
  Files         148      147       -1     
  Lines       12825    12666     -159     
==========================================
- Hits         4492     4471      -21     
+ Misses       7853     7712     -141     
- Partials      480      483       +3     

Impacted Files	Coverage Δ
bindings/aws/kinesis/kinesis.go	2.61% <0.00%> (ø)
bindings/azure/eventgrid/eventgrid.go	3.84% <0.00%> (ø)
bindings/mqtt/mqtt.go	25.00% <0.00%> (-1.42%)	⬇️
authentication/azure/auth.go	40.82% <2.04%> (-15.27%)	⬇️
secretstores/azure/keyvault/keyvault.go	36.25% <33.33%> (+2.00%)	⬆️
pubsub/rabbitmq/rabbitmq.go	57.14% <46.03%> (-7.15%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 915180b...20fe589. Read the comment docs.

[CodeMonkeyLeet]

The issues are being generated upstream by the dapr/dapr protoc version referencing a deprecated library. That has been fixed as part of dapr/dapr#3933 and needs to be propagated back to the certification tests (i.e. run go get github.com/dapr/dapr@<commit or tag with fix> in each of the tests/certification folders with go.mod.)

@artursouza @berndverst Right now the commit points to master which makes the version look like a downgrade. It looks like the go get is inferring this from the most recent version tag in master, and the v1.5.0 tag points to a merge commit that is only in the release branch and not an actual code commit that is shared between the master and release branches ... might be something to keep in mind for the next hotfix release.

[beiwei30]

The issues are being generated upstream by the dapr/dapr protoc version referencing a deprecated library. That has been fixed as part of dapr/dapr#3933 and needs to be propagated back to the certification tests (i.e. run go get github.com/dapr/dapr@<commit or tag with fix> in each of the tests/certification folders with go.mod.)

@artursouza @berndverst Right now the commit points to master which makes the version look like a downgrade. It looks like the go get is inferring this from the most recent version tag in master, and the v1.5.0 tag points to a merge commit that is only in the release branch and not an actual code commit that is shared between the master and release branches ... might be something to keep in mind for the next hotfix release.

@CodeMonkeyLeet Then I will close this PR and try to fix the issue by pinning dapr to later commit.