Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rabbitmq publisher confirm #1762

Merged
merged 5 commits into from
Jun 10, 2022

Conversation

ItalyPaleAle
Copy link
Contributor

@ItalyPaleAle ItalyPaleAle commented May 26, 2022

(This is based on #1756 so marking as draft until that's ready and merged)

Adds a new metadata key publisherConfirm for RabbitMQ that enables waiting for publish confirmation from the server (off by default). See: https://www.rabbitmq.com/confirms.html#publisher-confirms

Signed-off-by: ItalyPaleAle <43508+ItalyPaleAle@users.noreply.github.com>
berndverst
berndverst previously approved these changes Jun 7, 2022
@ItalyPaleAle ItalyPaleAle marked this pull request as ready for review June 7, 2022 23:26
@ItalyPaleAle ItalyPaleAle requested review from a team as code owners June 7, 2022 23:26
@ItalyPaleAle ItalyPaleAle changed the title Rabbitmq publish confirm Rabbitmq publisher confirm Jun 10, 2022
Signed-off-by: ItalyPaleAle <43508+ItalyPaleAle@users.noreply.github.com>
@berndverst
Copy link
Member

@ItalyPaleAle please open a Docs PR to document this metadata option.

@berndverst berndverst added this to the v1.8 milestone Jun 10, 2022
@berndverst berndverst added the documentation required This issue needs documentation label Jun 10, 2022
@codecov
Copy link

codecov bot commented Jun 10, 2022

Codecov Report

Merging #1762 (8774eda) into master (4322a22) will increase coverage by 0.00%.
The diff coverage is 36.66%.

@@           Coverage Diff           @@
##           master    #1762   +/-   ##
=======================================
  Coverage   36.59%   36.60%           
=======================================
  Files         177      177           
  Lines       16222    16244   +22     
=======================================
+ Hits         5937     5946    +9     
- Misses       9617     9627   +10     
- Partials      668      671    +3     
Impacted Files Coverage Δ
pubsub/rabbitmq/rabbitmq.go 55.39% <0.00%> (-2.31%) ⬇️
state/postgresql/postgresdbaccess.go 37.05% <0.00%> (-1.56%) ⬇️
pubsub/rabbitmq/metadata.go 93.93% <100.00%> (+0.39%) ⬆️
state/in-memory/in_memory.go 42.60% <0.00%> (+3.55%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7145287...8774eda. Read the comment docs.

@berndverst berndverst merged commit 6f3234d into dapr:master Jun 10, 2022
@ItalyPaleAle
Copy link
Contributor Author

ItalyPaleAle commented Jun 10, 2022

Opened docs PR: dapr/docs#2515

@ItalyPaleAle ItalyPaleAle deleted the rabbitmq-publish-confirm branch June 10, 2022 20:19
ItalyPaleAle added a commit to ItalyPaleAle/dapr-docs that referenced this pull request Jun 10, 2022
Added publisherConfirms. See dapr/components-contrib#1762

Signed-off-by: ItalyPaleAle <43508+ItalyPaleAle@users.noreply.github.com>
ItalyPaleAle added a commit to ItalyPaleAle/dapr-docs that referenced this pull request Jun 10, 2022
Added publisherConfirms. See dapr/components-contrib#1762

Signed-off-by: ItalyPaleAle <43508+ItalyPaleAle@users.noreply.github.com>
ItalyPaleAle added a commit to ItalyPaleAle/dapr-docs that referenced this pull request Jun 13, 2022
Added publisherConfirms. See dapr/components-contrib#1762

Signed-off-by: ItalyPaleAle <43508+ItalyPaleAle@users.noreply.github.com>
msfussell added a commit to dapr/docs that referenced this pull request Jun 14, 2022
Added publisherConfirms. See dapr/components-contrib#1762

Signed-off-by: ItalyPaleAle <43508+ItalyPaleAle@users.noreply.github.com>

Co-authored-by: Mark Fussell <markfussell@gmail.com>
artursouza pushed a commit to artursouza/docs that referenced this pull request Jun 14, 2022
Added publisherConfirms. See dapr/components-contrib#1762

Signed-off-by: ItalyPaleAle <43508+ItalyPaleAle@users.noreply.github.com>

Co-authored-by: Mark Fussell <markfussell@gmail.com>
Signed-off-by: Artur Souza <artursouza.ms@outlook.com>
msfussell added a commit to dapr/docs that referenced this pull request Jun 14, 2022
* Actor reminder partition as stable feature.

Signed-off-by: Artur Souza <artursouza.ms@outlook.com>

* Update PostgreSQL status (#2522)

Signed-off-by: Yaron Schneider <schneider.yaron@live.com>
Signed-off-by: Artur Souza <artursouza.ms@outlook.com>

* Update daprdocs/content/en/operations/support/support-preview-features.md

Co-authored-by: Mark Fussell <markfussell@gmail.com>
Signed-off-by: Artur Souza <artursouza.ms@outlook.com>

* Add dead letter topics info (#2500)

* Add dead letter topics info

Signed-off-by: yaron2 <schneider.yaron@live.com>

* fix typo

Signed-off-by: yaron2 <schneider.yaron@live.com>

* Update daprdocs/content/en/developing-applications/building-blocks/pubsub/pubsub-deadletter.md

Co-authored-by: Mark Fussell <markfussell@gmail.com>

* change dlt name

Signed-off-by: yaron2 <schneider.yaron@live.com>

* rephrase

Signed-off-by: yaron2 <schneider.yaron@live.com>

* rephrase

Signed-off-by: yaron2 <schneider.yaron@live.com>

* add pub/sub overview section

Signed-off-by: yaron2 <schneider.yaron@live.com>

* change weight

Signed-off-by: yaron2 <schneider.yaron@live.com>

* fix url

Signed-off-by: yaron2 <schneider.yaron@live.com>

* fix url

Signed-off-by: yaron2 <schneider.yaron@live.com>

* Update daprdocs/content/en/developing-applications/building-blocks/pubsub/pubsub-deadletter.md

Co-authored-by: Mark Fussell <markfussell@gmail.com>

* Update daprdocs/content/en/developing-applications/building-blocks/pubsub/pubsub-deadletter.md

Co-authored-by: Mark Fussell <markfussell@gmail.com>

* Update daprdocs/content/en/developing-applications/building-blocks/pubsub/pubsub-deadletter.md

Co-authored-by: Mark Fussell <markfussell@gmail.com>

* Update daprdocs/content/en/developing-applications/building-blocks/pubsub/pubsub-deadletter.md

Co-authored-by: Mark Fussell <markfussell@gmail.com>

* Update daprdocs/content/en/developing-applications/building-blocks/pubsub/pubsub-deadletter.md

Co-authored-by: Mark Fussell <markfussell@gmail.com>

* Update daprdocs/content/en/developing-applications/building-blocks/pubsub/pubsub-deadletter.md

Co-authored-by: Mark Fussell <markfussell@gmail.com>

* Update daprdocs/content/en/developing-applications/building-blocks/pubsub/pubsub-deadletter.md

Co-authored-by: Mark Fussell <markfussell@gmail.com>

* Update daprdocs/content/en/developing-applications/building-blocks/pubsub/pubsub-deadletter.md

Co-authored-by: Mark Fussell <markfussell@gmail.com>

* Update daprdocs/content/en/developing-applications/building-blocks/pubsub/pubsub-deadletter.md

Co-authored-by: Mark Fussell <markfussell@gmail.com>

* Update daprdocs/content/en/developing-applications/building-blocks/pubsub/pubsub-deadletter.md

Co-authored-by: Mark Fussell <markfussell@gmail.com>

* Update daprdocs/content/en/developing-applications/building-blocks/pubsub/pubsub-overview.md

Co-authored-by: Mark Fussell <markfussell@gmail.com>

* typo

Signed-off-by: yaron2 <schneider.yaron@live.com>

* add diagram

Signed-off-by: yaron2 <schneider.yaron@live.com>

Co-authored-by: Mark Fussell <markfussell@gmail.com>
Signed-off-by: Artur Souza <artursouza.ms@outlook.com>

* Updated pubsub.rabbitmq docs (#2515)

Added publisherConfirms. See dapr/components-contrib#1762

Signed-off-by: ItalyPaleAle <43508+ItalyPaleAle@users.noreply.github.com>

Co-authored-by: Mark Fussell <markfussell@gmail.com>
Signed-off-by: Artur Souza <artursouza.ms@outlook.com>

* Update daprdocs/content/en/developing-applications/building-blocks/actors/howto-actors.md

Co-authored-by: Mark Fussell <markfussell@gmail.com>
Signed-off-by: Artur Souza <artursouza.ms@outlook.com>

Co-authored-by: Yaron Schneider <schneider.yaron@live.com>
Co-authored-by: Mark Fussell <markfussell@gmail.com>
Co-authored-by: Alessandro (Ale) Segala <43508+ItalyPaleAle@users.noreply.github.com>
@berndverst berndverst removed the documentation required This issue needs documentation label Jun 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants