-
Notifications
You must be signed in to change notification settings - Fork 465
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Redis StateStore Certification Tests #1763
Conversation
Signed-off-by: Deepanshu Agarwal <deepanshu.agarwal1984@gmail.com>
Signed-off-by: Deepanshu Agarwal <deepanshu.agarwal1984@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You will also add your tests to the certification workflow here:
https://github.com/dapr/components-contrib/blob/master/.github/workflows/certification.yml#L55
And please note that this workflow will not actually run on this PR, so the fact that tests pass on this PR means nothing -- your certification tests are not being run.
A reviewer will need to manually run your PR to verify.
@DeepanshuA You can run the cert test on your forked repo like what I do as this page: https://github.com/skyao/components-contrib/actions/workflows/certification.yml You can run it on your branch: |
@DeepanshuA you need to update the workflow files in your PR to add your cert test case into the github action This is also an example from my PR (yes, I'm adding cert test for kakfa bindings now): |
Signed-off-by: Deepanshu Agarwal <deepanshu.agarwal1984@gmail.com>
thanks @berndverst and @skyao, I was able to run successfully the redis certification test on my fork: https://github.com/DeepanshuA/components-contrib/runs/6623705548?check_suite_focus=true |
@DeepanshuA , please, resolve conflicts. |
Hi @artursouza , resolved conflicts |
Signed-off-by: Bernd Verst <4535280+berndverst@users.noreply.github.com>
Codecov Report
@@ Coverage Diff @@
## master #1763 +/- ##
=======================================
Coverage 36.59% 36.59%
=======================================
Files 177 177
Lines 16222 16222
=======================================
Hits 5937 5937
Misses 9617 9617
Partials 668 668 Continue to review full report at Codecov.
|
Signed-off-by: Deepanshu Agarwal deepanshu.agarwal1984@gmail.com
Description
Adding Redis Certification test as per Test plan #1534 (comment)
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #1534
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: