Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Redis StateStore Certification Tests #1763

Merged
merged 6 commits into from
Jun 8, 2022

Conversation

DeepanshuA
Copy link
Contributor

Signed-off-by: Deepanshu Agarwal deepanshu.agarwal1984@gmail.com

Description

Adding Redis Certification test as per Test plan #1534 (comment)

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #1534

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation / Created issue in the https://github.com/dapr/docs/ repo: dapr/docs#[issue number]

Signed-off-by: Deepanshu Agarwal <deepanshu.agarwal1984@gmail.com>
Signed-off-by: Deepanshu Agarwal <deepanshu.agarwal1984@gmail.com>
@DeepanshuA DeepanshuA requested review from a team as code owners May 26, 2022 21:40
@DeepanshuA DeepanshuA changed the title Add Redis Certification Tests Add Redis StateStore Certification Tests May 26, 2022
Copy link
Member

@berndverst berndverst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You will also add your tests to the certification workflow here:
https://github.com/dapr/components-contrib/blob/master/.github/workflows/certification.yml#L55

And please note that this workflow will not actually run on this PR, so the fact that tests pass on this PR means nothing -- your certification tests are not being run.

A reviewer will need to manually run your PR to verify.

@skyao
Copy link
Member

skyao commented May 27, 2022

@DeepanshuA You can run the cert test on your forked repo like what I do as this page:

https://github.com/skyao/components-contrib/actions/workflows/certification.yml

You can run it on your branch:

Screen Shot 2022-05-27 at 11 01 44

@skyao
Copy link
Member

skyao commented May 27, 2022

@DeepanshuA you need to update the workflow files in your PR to add your cert test case into the github action

This is also an example from my PR (yes, I'm adding cert test for kakfa bindings now):

Screen Shot 2022-05-27 at 11 04 16

https://github.com/dapr/components-contrib/pull/1758/files#diff-d519a9b910e45c00725de9beec3fbc97be24eaf1586c66943a17b7908b115f1c

Signed-off-by: Deepanshu Agarwal <deepanshu.agarwal1984@gmail.com>
@DeepanshuA
Copy link
Contributor Author

thanks @berndverst and @skyao, I was able to run successfully the redis certification test on my fork:

https://github.com/DeepanshuA/components-contrib/runs/6623705548?check_suite_focus=true

@artursouza
Copy link
Member

@DeepanshuA , please, resolve conflicts.

@DeepanshuA
Copy link
Contributor Author

DeepanshuA commented Jun 7, 2022

@DeepanshuA , please, resolve conflicts.

Hi @artursouza , resolved conflicts

Signed-off-by: Bernd Verst <4535280+berndverst@users.noreply.github.com>
@codecov
Copy link

codecov bot commented Jun 7, 2022

Codecov Report

Merging #1763 (c9f9d58) into master (4322a22) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1763   +/-   ##
=======================================
  Coverage   36.59%   36.59%           
=======================================
  Files         177      177           
  Lines       16222    16222           
=======================================
  Hits         5937     5937           
  Misses       9617     9617           
  Partials      668      668           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4322a22...c9f9d58. Read the comment docs.

@berndverst berndverst merged commit 1af102f into dapr:master Jun 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add certification tests for Redis
4 participants