-
Notifications
You must be signed in to change notification settings - Fork 467
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bumped dapr/dapr in cert tests #1773
Conversation
Signed-off-by: ItalyPaleAle <43508+ItalyPaleAle@users.noreply.github.com>
@@ -358,6 +358,8 @@ require ( | |||
sigs.k8s.io/yaml v1.3.0 // indirect | |||
) | |||
|
|||
replace go.opentelemetry.io/otel => go.opentelemetry.io/otel v0.20.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Explained: dapr/dapr#4708
Signed-off-by: ItalyPaleAle <43508+ItalyPaleAle@users.noreply.github.com>
/ok-to-test Conformance: https://github.com/dapr/components-contrib/actions/runs/2436230474 |
@ItalyPaleAle let me know when you're comfortable to merge. |
Signed-off-by: ItalyPaleAle <43508+ItalyPaleAle@users.noreply.github.com>
@yaron2 I just pushed another commit as when the PR was merged, a go.mod file was accidentally deleted. There are still 3 failing tests:
Fixing the last one will be a hard requirement for me. However I understand this PR is pretty urgent either, so if you want to go ahead and merge it, I can make a follow-up to fix the Event Hubs conformance test. |
Signed-off-by: ItalyPaleAle <43508+ItalyPaleAle@users.noreply.github.com>
Signed-off-by: ItalyPaleAle <43508+ItalyPaleAle@users.noreply.github.com>
Codecov Report
@@ Coverage Diff @@
## master #1773 +/- ##
==========================================
- Coverage 36.74% 36.61% -0.13%
==========================================
Files 176 177 +1
Lines 15955 16208 +253
==========================================
+ Hits 5863 5935 +72
- Misses 9434 9605 +171
- Partials 658 668 +10
Continue to review full report at Codecov.
|
/ok-to-test Conformance: https://github.com/dapr/components-contrib/actions/runs/2436808471 |
I fixed the issue with Event Hubs |
SHould make the cert tests work again after the interface for pubsub has changed