Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bumped dapr/dapr in cert tests #1773

Merged
merged 5 commits into from
Jun 7, 2022
Merged

Conversation

ItalyPaleAle
Copy link
Contributor

SHould make the cert tests work again after the interface for pubsub has changed

Signed-off-by: ItalyPaleAle <43508+ItalyPaleAle@users.noreply.github.com>
@@ -358,6 +358,8 @@ require (
sigs.k8s.io/yaml v1.3.0 // indirect
)

replace go.opentelemetry.io/otel => go.opentelemetry.io/otel v0.20.0
Copy link
Contributor Author

@ItalyPaleAle ItalyPaleAle Jun 3, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Explained: dapr/dapr#4708

Signed-off-by: ItalyPaleAle <43508+ItalyPaleAle@users.noreply.github.com>
@ItalyPaleAle
Copy link
Contributor Author

ItalyPaleAle commented Jun 3, 2022

yaron2
yaron2 previously approved these changes Jun 3, 2022
@yaron2
Copy link
Member

yaron2 commented Jun 3, 2022

@ItalyPaleAle let me know when you're comfortable to merge.

Signed-off-by: ItalyPaleAle <43508+ItalyPaleAle@users.noreply.github.com>
@ItalyPaleAle
Copy link
Contributor Author

@yaron2 I just pushed another commit as when the PR was merged, a go.mod file was accidentally deleted.

There are still 3 failing tests:

  • certification for Event Hubs -> that test is broken so it's ok
  • certification for Kafka (pubsub and binding) -> those are flaky and are passing ~50% of times. @skyao is looking into those
  • conformance for Event Hubs -> investigating this

Fixing the last one will be a hard requirement for me.

However I understand this PR is pretty urgent either, so if you want to go ahead and merge it, I can make a follow-up to fix the Event Hubs conformance test.

Signed-off-by: ItalyPaleAle <43508+ItalyPaleAle@users.noreply.github.com>
artursouza
artursouza previously approved these changes Jun 3, 2022
Signed-off-by: ItalyPaleAle <43508+ItalyPaleAle@users.noreply.github.com>
@codecov
Copy link

codecov bot commented Jun 3, 2022

Codecov Report

Merging #1773 (8c8fe5e) into master (e2aced1) will decrease coverage by 0.12%.
The diff coverage is 20.30%.

@@            Coverage Diff             @@
##           master    #1773      +/-   ##
==========================================
- Coverage   36.74%   36.61%   -0.13%     
==========================================
  Files         176      177       +1     
  Lines       15955    16208     +253     
==========================================
+ Hits         5863     5935      +72     
- Misses       9434     9605     +171     
- Partials      658      668      +10     
Impacted Files Coverage Δ
bindings/alicloud/dingtalk/webhook/webhook.go 52.68% <ø> (ø)
bindings/alicloud/nacos/nacos.go 35.60% <ø> (ø)
bindings/alicloud/rocketmq/rocketmq.go 0.00% <ø> (ø)
bindings/aws/kinesis/kinesis.go 2.61% <ø> (ø)
bindings/aws/sqs/sqs.go 6.55% <ø> (ø)
bindings/azure/eventgrid/eventgrid.go 3.84% <ø> (ø)
bindings/azure/eventhubs/eventhubs.go 14.79% <ø> (ø)
...indings/azure/servicebusqueues/servicebusqueues.go 10.69% <ø> (ø)
bindings/azure/storagequeues/storagequeues.go 33.87% <ø> (ø)
bindings/cron/cron.go 87.23% <ø> (ø)
... and 35 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 704f4dd...8c8fe5e. Read the comment docs.

@ItalyPaleAle
Copy link
Contributor Author

ItalyPaleAle commented Jun 3, 2022

@ItalyPaleAle
Copy link
Contributor Author

I fixed the issue with Event Hubs

@berndverst berndverst merged commit 157ddc6 into dapr:master Jun 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants