Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve log of kafka components cert test #1800

Merged
merged 1 commit into from Jun 20, 2022

Conversation

skyao
Copy link
Member

@skyao skyao commented Jun 20, 2022

Description

improve log of kafkaf components cert test

Issue reference

#1799

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation / Created issue in the https://github.com/dapr/docs/ repo: dapr/docs#[issue number]

Signed-off-by: Sky Ao <aoxiaojian@gmail.com>
@skyao skyao requested review from a team as code owners June 20, 2022 16:23
@codecov
Copy link

codecov bot commented Jun 20, 2022

Codecov Report

Merging #1800 (3a5ef90) into master (4322a22) will increase coverage by 0.25%.
The diff coverage is 22.66%.

@@            Coverage Diff             @@
##           master    #1800      +/-   ##
==========================================
+ Coverage   36.59%   36.85%   +0.25%     
==========================================
  Files         177      179       +2     
  Lines       16222    16263      +41     
==========================================
+ Hits         5937     5993      +56     
+ Misses       9617     9577      -40     
- Partials      668      693      +25     
Impacted Files Coverage Δ
authentication/azure/auth.go 38.12% <0.00%> (ø)
...indings/azure/servicebusqueues/servicebusqueues.go 2.02% <0.00%> (-8.67%) ⬇️
bindings/redis/redis.go 18.18% <0.00%> (-2.88%) ⬇️
bindings/zeebe/client.go 27.27% <ø> (ø)
bindings/zeebe/command/command.go 87.50% <ø> (ø)
bindings/zeebe/command/complete_job.go 64.70% <ø> (ø)
bindings/zeebe/command/create_instance.go 77.77% <ø> (ø)
bindings/zeebe/command/update_job_retries.go 71.42% <ø> (ø)
bindings/zeebe/jobworker/jobworker.go 11.34% <ø> (ø)
internal/component/kafka/consumer.go 0.00% <0.00%> (ø)
... and 32 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 55888c0...3a5ef90. Read the comment docs.

@ItalyPaleAle ItalyPaleAle changed the title improve log of kafkaf components cert test improve log of kafka components cert test Jun 20, 2022
@berndverst berndverst merged commit d6dd10e into dapr:master Jun 20, 2022
@skyao skyao deleted the improve-kafka-log branch January 2, 2024 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants