Certification test for Azure CosmosDB Statestore #1972

shivamkm07 · 2022-08-16T18:51:18Z

Signed-off-by: shivam shivamkm07@gmail.com

Description

Certification test for Azure CosmosDB statestore

Issue reference

Please reference the issue this PR will close: #1138

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

Code compiles correctly
Created/updated tests
Extended the documentation / Created issue in the https://github.com/dapr/docs/ repo: dapr/docs#[issue number]

codecov · 2022-08-16T19:04:56Z

Codecov Report

Merging #1972 (fcfcda7) into master (ebaa1b5) will decrease coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1972      +/-   ##
==========================================
- Coverage   37.71%   37.67%   -0.04%     
==========================================
  Files         192      192              
  Lines       24016    24016              
==========================================
- Hits         9058     9049       -9     
- Misses      14189    14199      +10     
+ Partials      769      768       -1

Impacted Files	Coverage Δ
state/in-memory/in_memory.go	`42.58% <0.00%> (-3.43%)`	⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

DeepanshuA · 2022-08-17T07:54:33Z

tests/certification/state/azure/cosmosdb/cosmosdb_test.go

+				assert.Equal(t, expectedValue, string(item.Value))
+
+				// delete state
+				err = client.DeleteState(ctx, statestore, stateKey, setMeta)


Should we also try to delete with wrong partition key and assert error?

berndverst · 2022-08-18T19:17:28Z

tests/certification/state/azure/cosmosdb/README.md

+
+## Test plan
+
+### Basic Test using master key authentication


Please remove this. It's already covered by conformance tests.

berndverst · 2022-08-18T19:31:05Z

tests/certification/state/azure/cosmosdb/README.md

+
+### Test Partition Keys
+Ensure the following scenarios:
+ 1. In case of invalid partition key, the access fails


Access? That sounds like it's about authorization.. but that's not so.

Please be specific that this is about a Get or Set operation.

berndverst · 2022-08-18T19:40:59Z

tests/certification/state/azure/cosmosdb/README.md

+1. Able to create and test connection.
+2. Able to do set, fetch and delete.
+
+### Test Partition Keys


Please add a test where you are connecting to a different collection -- a collection which does not use the expected /partitionKey partition key. We want to assert the failure for that case. This is a common problem.

To do so, please add a new collection with wrong partition name here:
https://github.com/dapr/components-contrib/blob/master/.github/infrastructure/conformance/azure/conf-test-azure-cosmosdb.bicep#L44

Then also make sure to update the following so that the second collection name gets exported to the KeyVault where we save these configurations
https://github.com/dapr/components-contrib/blob/master/.github/infrastructure/conformance/azure/conf-test-azure.bicep
https://github.com/dapr/components-contrib/blob/master/.github/infrastructure/conformance/azure/setup-azure-conf-test.sh

Lastly, set up a new component YAML talking to the collection with the bad partition name. And make sure to reference the new environment variable you are creating above.

Don't forget to inject that environment variable into the workflow run via the required-secrets section!

To provide more context -- what you have described is only impacting partition key values, but the Cosmos DB state store requires that the Cosmos DB collection was setup with a partition Key that is exactly called /partitionKey. It will be good to assert the failure when the collection has been set up wrong.

berndverst

Please also add tests that check the handling of null data, empty string - especially with different content types specified.

#1974

mukundansundar · 2022-08-20T06:27:43Z

Please also add tests that check the handling of null data, empty string - especially with different content types specified.

#1974

@berndverst should the nil, empty string test be part of conformance tests?

DeepanshuA · 2022-08-22T04:53:56Z

@berndverst Please advise, does it make sense to include this test as well? :
#1138 (comment)

berndverst · 2022-08-22T18:22:39Z

@berndverst Please advise, does it make sense to include this test as well? : #1138 (comment)

Ok to skip, I am going to add it here: #1992

berndverst

@shivamkm07 please address review comments.

tests/certification/state/azure/cosmosdb/cosmosdb_test.go

tests/certification/state/azure/cosmosdb/go.mod

Signed-off-by: shivam <shivamkm07@gmail.com>

Signed-off-by: Bernd Verst <4535280+berndverst@users.noreply.github.com>

berndverst

We depend on this PR to upgrade the Track2 SDK. Therefore I will merge this now -- I fixed this up as necessary.

* Certification test for Azure CosmosDB Signed-off-by: shivam <shivamkm07@gmail.com> * Updating go.mod Signed-off-by: shivam <shivamkm07@gmail.com> * make motidy-all Signed-off-by: Bernd Verst <4535280+berndverst@users.noreply.github.com> * CosmosDB Cert Test: Apply Dapr Runtime updates, Go version update etc Signed-off-by: Bernd Verst <4535280+berndverst@users.noreply.github.com> Signed-off-by: shivam <shivamkm07@gmail.com> Signed-off-by: Bernd Verst <4535280+berndverst@users.noreply.github.com> Co-authored-by: Bernd Verst <4535280+berndverst@users.noreply.github.com> Signed-off-by: Bernd Verst <4535280+berndverst@users.noreply.github.com>

* Certification test for Azure CosmosDB Signed-off-by: shivam <shivamkm07@gmail.com> * Updating go.mod Signed-off-by: shivam <shivamkm07@gmail.com> * make motidy-all Signed-off-by: Bernd Verst <4535280+berndverst@users.noreply.github.com> * CosmosDB Cert Test: Apply Dapr Runtime updates, Go version update etc Signed-off-by: Bernd Verst <4535280+berndverst@users.noreply.github.com> Signed-off-by: shivam <shivamkm07@gmail.com> Signed-off-by: Bernd Verst <4535280+berndverst@users.noreply.github.com> Co-authored-by: Bernd Verst <4535280+berndverst@users.noreply.github.com>

shivamkm07 requested review from a team as code owners August 16, 2022 18:51

DeepanshuA reviewed Aug 17, 2022

View reviewed changes

berndverst reviewed Aug 18, 2022

View reviewed changes

berndverst requested changes Aug 18, 2022

View reviewed changes

berndverst requested changes Aug 20, 2022

View reviewed changes

berndverst mentioned this pull request Aug 31, 2022

Upgrading cosmosdb statestore to track2SDK #2035

Merged

berndverst requested changes Aug 31, 2022

View reviewed changes

ItalyPaleAle reviewed Aug 31, 2022

View reviewed changes

tests/certification/state/azure/cosmosdb/cosmosdb_test.go Show resolved Hide resolved

tests/certification/state/azure/cosmosdb/go.mod Outdated Show resolved Hide resolved

tests/certification/state/azure/cosmosdb/go.mod Outdated Show resolved Hide resolved

shivamkm07 and others added 3 commits September 8, 2022 14:48

Certification test for Azure CosmosDB

b2f7853

Signed-off-by: shivam <shivamkm07@gmail.com>

Updating go.mod

c73160b

Signed-off-by: shivam <shivamkm07@gmail.com>

make motidy-all

0bca135

Signed-off-by: Bernd Verst <4535280+berndverst@users.noreply.github.com>

berndverst force-pushed the cosmosdb_certTest branch from e029f31 to 6a6c465 Compare September 8, 2022 21:49

CosmosDB Cert Test: Apply Dapr Runtime updates, Go version update etc

fcfcda7

Signed-off-by: Bernd Verst <4535280+berndverst@users.noreply.github.com>

berndverst force-pushed the cosmosdb_certTest branch from 6a6c465 to fcfcda7 Compare September 8, 2022 21:54

berndverst approved these changes Sep 8, 2022

View reviewed changes

berndverst added the automerge label Sep 8, 2022

dapr-bot merged commit 2b5650c into dapr:master Sep 8, 2022

berndverst added this to the v1.9 milestone Oct 4, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Certification test for Azure CosmosDB Statestore #1972

Certification test for Azure CosmosDB Statestore #1972

shivamkm07 commented Aug 16, 2022

codecov bot commented Aug 16, 2022 •

edited

DeepanshuA Aug 17, 2022

berndverst Aug 18, 2022

berndverst Aug 18, 2022

berndverst Aug 18, 2022

berndverst Aug 31, 2022

berndverst left a comment

mukundansundar commented Aug 20, 2022

DeepanshuA commented Aug 22, 2022

berndverst commented Aug 22, 2022

berndverst left a comment

berndverst left a comment

Certification test for Azure CosmosDB Statestore #1972

Certification test for Azure CosmosDB Statestore #1972

Conversation

shivamkm07 commented Aug 16, 2022

Description

Issue reference

Checklist

codecov bot commented Aug 16, 2022 • edited

Codecov Report

DeepanshuA Aug 17, 2022

Choose a reason for hiding this comment

berndverst Aug 18, 2022

Choose a reason for hiding this comment

berndverst Aug 18, 2022

Choose a reason for hiding this comment

berndverst Aug 18, 2022

Choose a reason for hiding this comment

berndverst Aug 31, 2022

Choose a reason for hiding this comment

berndverst left a comment

Choose a reason for hiding this comment

mukundansundar commented Aug 20, 2022

DeepanshuA commented Aug 22, 2022

berndverst commented Aug 22, 2022

berndverst left a comment

Choose a reason for hiding this comment

berndverst left a comment

Choose a reason for hiding this comment

codecov bot commented Aug 16, 2022 •

edited