RabbitMQ Bindings: Support for mTLS and external authentication with SASL #2656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please ignore until #2515 is merged. |
abossard
force-pushed
the
feature/rabbitmq_bindings_mtls_external_sasl
branch
from
72907aa
to
c693ee6
Compare
Signed-off-by: Andre Bossard <anbossar@microsoft.com>
abossard
force-pushed
the
feature/rabbitmq_bindings_mtls_external_sasl
branch
from
c693ee6
to
2e9c849
Compare
|
I'll take a peek later today and complete it. Thanks for the patience. |
Signed-off-by: Andre Bossard <abossard@users.noreply.github.com>
Signed-off-by: Andre Bossard <anbossar@microsoft.com>
Signed-off-by: Andre Bossard <anbossar@microsoft.com>
Signed-off-by: Andre Bossard <anbossar@microsoft.com>
abossard
force-pushed
the
feature/rabbitmq_bindings_mtls_external_sasl
branch
from
90dd61c
to
2ffc590
Compare
berndverst
requested changes
May 1, 2023
There was a problem hiding this comment.
Something about the certification test changes is still wrong. Maybe the Docker file paths? I remember that being an issue with the pubsub component.
Also please note we have code freeze very very soon, so if you can get the tests to pass we can include this in 1.11.
To run certification tests locally navigate to tests/certification/bindings/rabbitmq and run:
export GOLANG_PROTOBUF_REGISTRATION_CONFLICT=ignore
go test -v --count=1 .
=== FAIL: bindings/rabbitmq TestRabbitMQExtAuth/rabbitmq_certification (1.03s)
flow.go:220: Running step: rabbitmqcertification
dockercompose.go:57: build path /home/runner/work/components-contrib/components-contrib/tests/certification/bindings/rabbitmq/mtls_sasl_external/mtls_sasl_external/docker_sasl_external either does not exist, is not accessible, or is not a valid URL.
flow.go:228: Completed step: rabbitmqcertification
flow.go:230: Fatal error in step rabbitmqcertification: exit status 1
dockercompose.go:72: build path /home/runner/work/components-contrib/components-contrib/tests/certification/bindings/rabbitmq/mtls_sasl_external/mtls_sasl_external/docker_sasl_external either does not exist, is not accessible, or is not a valid URL.
Signed-off-by: Andre Bossard <anbossar@microsoft.com>
|
Hi @berndverst thank, yeah again it was in the docker-compose.yaml a wrong path. Funnily enough it works with Docker Desktop on Mac, but not with Docker on Linux. Fixed and pushed it. |
berndverst
approved these changes
May 3, 2023
7 tasks
aaguilartablada
pushed a commit
to aaguilartablada/dapr-components-contrib
that referenced
this pull request
Jun 1, 2023
…SASL (dapr#2656) Signed-off-by: Andre Bossard <anbossar@microsoft.com> Signed-off-by: Andre Bossard <abossard@users.noreply.github.com> Co-authored-by: Andre Bossard <anbossar@microsoft.com> Co-authored-by: Deepanshu Agarwal <deepanshu.agarwal1984@gmail.com> Co-authored-by: Bernd Verst <github@bernd.dev> Signed-off-by: Alvaro Aguilar <alvaro.aguilar@scrm.lidl>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a port of #2515 to enable mTLS and External SASL based auth also in the Dapr bindings for RabbitMQ.
This is based on the EXTERNAL mechanism described here:
https://www.rabbitmq.com/access-control.html#mechanisms
Issue reference
#2514 but this time for the bindings
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: