Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Many fixes to Oracle Database state store - now beta #2702

Merged
merged 2 commits into from Mar 25, 2023

Conversation

ItalyPaleAle
Copy link
Contributor

Spin-off from #2688 as while working on that, I noticed the issues were much bigger than originally thought

Contains a large number of fixes, some critical, to the component:

  • State table name was hardcoded rather than read from the metadata
  • Transactions had queries executed in the wrong order: first all sets, then all deletes
  • Transactions were not concurrency-safe, since the transaction handler was stored as property in the object
  • TTLs were not updated when a row was updated
  • Lots more fixes

Conformance tests are now enabled and passing for the component

Contains a large number of fixes, some critical, to the component:

- State table name was hardcoded rather than read from the metadata
- Transactions had queries executed in the wrong order: first all sets, then all deletes
- Transactions were not concurrency-safe, since the transaction handler was stored as property in the object
- TTLs were not updated when a row was updated
- Lots more fixes

Conformance tests are now enabled and passing for the component

Signed-off-by: ItalyPaleAle <43508+ItalyPaleAle@users.noreply.github.com>
@berndverst berndverst added this pull request to the merge queue Mar 25, 2023
Merged via the queue into dapr:master with commit bc52e25 Mar 25, 2023
79 of 80 checks passed
@ItalyPaleAle ItalyPaleAle added this to the v1.11 milestone Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants