RethinkDB: Disable transactions that were not working #2733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The implementation of the "Multi" method in RethinkDB was not correct, as it caused operations to be executed in the wrong order and it was not using a transaction (per comment on code: `best effort, no transacts supported`) Signed-off-by: ItalyPaleAle <43508+ItalyPaleAle@users.noreply.github.com>
mukundansundar
approved these changes
Apr 3, 2023
mukundansundar
added
breaking-change
documentation required
Docs did not mention RethinkDB as supporting transactions: https://docs.dapr.io/reference/components-reference/supported-state-stores/ Because of that, and the fact that it's beta, I think this is not a breaking change (or at least not one we should be concerned with). |
ItalyPaleAle
removed
breaking-change
documentation required
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The implementation of the "Multi" method in RethinkDB was not correct, as it caused operations to be executed in the wrong order and it was not using a transaction (per comment on code:
best effort, no transacts supported)In essence, RethinkDB was not supporting transactions, and advertising the existence of the Multi method can cause users to believe it does, with dangerous potentials for data loss.