New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
state.sqlserver: Add support for Azure AD auth (+ metadata.yaml) #2790
Conversation
Signed-off-by: ItalyPaleAle <43508+ItalyPaleAle@users.noreply.github.com>
Signed-off-by: ItalyPaleAle <43508+ItalyPaleAle@users.noreply.github.com>
Signed-off-by: ItalyPaleAle <43508+ItalyPaleAle@users.noreply.github.com>
Signed-off-by: ItalyPaleAle <43508+ItalyPaleAle@users.noreply.github.com>
Signed-off-by: ItalyPaleAle <43508+ItalyPaleAle@users.noreply.github.com>
Signed-off-by: ItalyPaleAle <43508+ItalyPaleAle@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some nitpicks
Co-authored-by: Deepanshu Agarwal <deepanshu.agarwal1984@gmail.com> Signed-off-by: Alessandro (Ale) Segala <43508+ItalyPaleAle@users.noreply.github.com>
…r#2790) Signed-off-by: ItalyPaleAle <43508+ItalyPaleAle@users.noreply.github.com> Signed-off-by: Alessandro (Ale) Segala <43508+ItalyPaleAle@users.noreply.github.com> Co-authored-by: Deepanshu Agarwal <deepanshu.agarwal1984@gmail.com> Signed-off-by: ParrySMS <yh@szu.me>
Hi Team, Just want to say thank you for the work you are doing and have considered implementing support for AAD for the SQL server state store. Looking forward to version 1.11! We are using Dapr on Azure Container App. I hope the Azure team doesn't take long to update to the new version. |
Adds support for Azure AD authentication in the
state.sqlserver
component.Fixes #2726
useAzureAD: true
in the metadata.connectionString
is still required to include the URL of the database, the DB name, and any connection option. If it contains credentials, they are ignoredNote: I confirmed tests pass locally, but I can't easily add them to the certification tests because it appears I may need to create a separate Azure SQL instance to use Azure AD. I can look into doing that in a subsequent PR