Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rocketmq consumer support some config item #2811

Merged
merged 11 commits into from May 4, 2023

Conversation

naah69
Copy link
Contributor

@naah69 naah69 commented Apr 26, 2023

Description

support the below config item in rocketmq

ConsumeTimestamp
ConsumeConcurrentlyMaxSpan
ConsumeTimeout
ConsumerPullTimeout
PullThresholdForTopic
PullThresholdSizeForQueue
PullThresholdSizeForTopic

Issue reference

Please reference the issue this PR will close: #2756

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

Signed-off-by: Naah <nayan3480232@163.com>
@naah69 naah69 requested review from a team as code owners April 26, 2023 03:21
Copy link
Member

@berndverst berndverst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unit tests are failing.

time="2023-04-27T22:42:33.717240927Z" level=error msg="consumer start failed: the consumer group option validate fail: the specified group[dapr.rocketmq.producer] contains illegal characters, allowing only ^[%|a-zA-Z0-9_-]+$" instance=fv-az621-182 scope=test type=log ver=unknown

Run your tests with make test to make sure everything is passing please.

@berndverst
Copy link
Member

@naah69 our code freeze will occur any day now - possibly as soon as tomorrow. If the tests in this PR are not passing at that time then unfortunately this PR cannot be included in Dapr 1.11 and you need to wait for Dapr 1.12.

When you work on this PR please run the validations locally to avoid delay in review:

  • make test
  • make lint

Update this PR with all changes required to make those two commands pass.

Thanks!

naah69 added 4 commits May 4, 2023 04:17
Signed-off-by: Naah <nayan3480232@163.com>
Signed-off-by: Naah <nayan3480232@163.com>
@naah69
Copy link
Contributor Author

naah69 commented May 4, 2023

@naah69 our code freeze will occur any day now - possibly as soon as tomorrow. If the tests in this PR are not passing at that time then unfortunately this PR cannot be included in Dapr 1.11 and you need to wait for Dapr 1.12.

When you work on this PR please run the validations locally to avoid delay in review:

  • make test
  • make lint

Update this PR with all changes required to make those two commands pass.

Thanks!

ok,i had fixed it.
please review it.
Thanks

@berndverst berndverst added this to the v1.11 milestone May 4, 2023
@berndverst berndverst merged commit 615d491 into dapr:master May 4, 2023
81 checks passed
aaguilartablada pushed a commit to aaguilartablada/dapr-components-contrib that referenced this pull request Jun 1, 2023
Signed-off-by: Naah <nayan3480232@163.com>
Signed-off-by: Bernd Verst <github@bernd.dev>
Co-authored-by: Deepanshu Agarwal <deepanshu.agarwal1984@gmail.com>
Co-authored-by: Bernd Verst <github@bernd.dev>
Signed-off-by: Alvaro Aguilar <alvaro.aguilar@scrm.lidl>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[RocketMQ] is the consumeTimeout available? what the time unit is it?
3 participants