New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rocketmq consumer support some config item #2811
Conversation
Signed-off-by: Naah <nayan3480232@163.com>
Signed-off-by: Naah <nayan3480232@163.com>
Signed-off-by: Bernd Verst <github@bernd.dev>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unit tests are failing.
time="2023-04-27T22:42:33.717240927Z" level=error msg="consumer start failed: the consumer group option validate fail: the specified group[dapr.rocketmq.producer] contains illegal characters, allowing only ^[%|a-zA-Z0-9_-]+$" instance=fv-az621-182 scope=test type=log ver=unknown
Run your tests with make test
to make sure everything is passing please.
@naah69 our code freeze will occur any day now - possibly as soon as tomorrow. If the tests in this PR are not passing at that time then unfortunately this PR cannot be included in Dapr 1.11 and you need to wait for Dapr 1.12. When you work on this PR please run the validations locally to avoid delay in review:
Update this PR with all changes required to make those two commands pass. Thanks! |
…nts-contrib into rocketmq-consumer
ok,i had fixed it. |
Signed-off-by: Naah <nayan3480232@163.com> Signed-off-by: Bernd Verst <github@bernd.dev> Co-authored-by: Deepanshu Agarwal <deepanshu.agarwal1984@gmail.com> Co-authored-by: Bernd Verst <github@bernd.dev> Signed-off-by: Alvaro Aguilar <alvaro.aguilar@scrm.lidl>
Description
support the below config item in rocketmq
Issue reference
Please reference the issue this PR will close: #2756
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: