HTTP Binding: add "maxResponseBodySize" metadata option #3040
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ItalyPaleAle <43508+ItalyPaleAle@users.noreply.github.com>
Signed-off-by: ItalyPaleAle <43508+ItalyPaleAle@users.noreply.github.com>
Signed-off-by: ItalyPaleAle <43508+ItalyPaleAle@users.noreply.github.com>
berndverst
reviewed
Aug 4, 2023
berndverst
reviewed
Aug 4, 2023
Signed-off-by: ItalyPaleAle <43508+ItalyPaleAle@users.noreply.github.com>
Signed-off-by: ItalyPaleAle <43508+ItalyPaleAle@users.noreply.github.com>
Co-authored-by: Bernd Verst <github@bernd.dev> Signed-off-by: ItalyPaleAle <43508+ItalyPaleAle@users.noreply.github.com>
…nto ADA-DAPR-23-7
berndverst
previously approved these changes
Aug 11, 2023
…nto ADA-DAPR-23-7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the HTTP binding to add the "maxResponseBodySize" metadata option, which limits the amount of data read from response bodies.
This is necessary to prevent OOMs if the server returns too much data.
The default limit is 100 MiB. This may be considered a breaking change if users were using the binding to fetch very large payloads (which may not be a very efficient thing to do anyways). The breaking change is justified by the security aspect of this fix.
The "maxResponseBodySize" metadata is parsed as a resource, using the same library used by K8s. A number without unit is interpreted as bytes (e.g. "100"); units can be added such as "Mi", "M", etc. To be able to support resource quantities, new methods have been added to the metadata parser.