Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle object not found error in bindings: S3, Azure Blob Storage, GCP Bucket, Huawei OBS #3223

Merged
merged 4 commits into from Nov 13, 2023

Conversation

sadath-12
Copy link
Contributor

@sadath-12 sadath-12 commented Nov 10, 2023

Description

Added specific error handling to object not found mentioning the key so user is not frustated with unnecessary long errors

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #2526 _

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation / Created issue in the https://github.com/dapr/docs/ repo: dapr/docs#[issue number]

Signed-off-by: sadath-12 <sadathsadu2002@gmail.com>
@sadath-12 sadath-12 requested review from a team as code owners November 10, 2023 09:24
Copy link
Contributor

@ItalyPaleAle ItalyPaleAle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! This is a great start.

In addition to the comment I left, can you please update the certification tests to add a case of testing retrieving a file that doesn't exist?

bindings/aws/s3/s3.go Outdated Show resolved Hide resolved
Signed-off-by: sadath-12 <sadathsadu2002@gmail.com>
Signed-off-by: Alessandro (Ale) Segala <43508+ItalyPaleAle@users.noreply.github.com>
@ItalyPaleAle ItalyPaleAle changed the title enhancement: not found error handling Handle object not found error in bindings: S3, Azure Blob Storage, GCP Bucket, Huawei OBS Nov 10, 2023
@ItalyPaleAle
Copy link
Contributor

/ok-to-test

@dapr-bot
Copy link
Collaborator

Complete Build Matrix

The build status is currently not updated here. Please visit the action run below directly.

🔗 Link to Action run

Commit ref: 13779ba

@dapr-bot
Copy link
Collaborator

dapr-bot commented Nov 10, 2023

Components certification test

🔗 Link to Action run

Commit ref: 13779ba

❌ Some certification tests failed

These tests failed:

  • pubsub.mqtt3
  • secretstores.hashicorp.vault

@dapr-bot
Copy link
Collaborator

dapr-bot commented Nov 10, 2023

Components conformance test

🔗 Link to Action run

Commit ref: 13779ba

✅ All conformance tests passed

All tests have reported a successful status

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are almost done - you still need to format this file properly - that is done with the gofumpt tool. There are other files that need to be formatted as well - see the linter error (make lint to run the linter locally)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @berndverst 🙂

Signed-off-by: sadath-12 <sadathsadu2002@gmail.com>
@berndverst
Copy link
Member

/ok-to-test

@dapr-bot
Copy link
Collaborator

Complete Build Matrix

The build status is currently not updated here. Please visit the action run below directly.

🔗 Link to Action run

Commit ref: fee4335

@dapr-bot
Copy link
Collaborator

dapr-bot commented Nov 13, 2023

Components conformance test

🔗 Link to Action run

Commit ref: fee4335

✅ All conformance tests passed

All tests have reported a successful status

@dapr-bot
Copy link
Collaborator

dapr-bot commented Nov 13, 2023

Components certification test

🔗 Link to Action run

Commit ref: fee4335

❌ Some certification tests failed

These tests failed:

  • bindings.azure.storagequeues
  • pubsub.mqtt3
  • secretstores.hashicorp.vault

@berndverst berndverst merged commit 95690ac into dapr:main Nov 13, 2023
83 of 87 checks passed
@berndverst berndverst added this to the v1.13 milestone Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve "File not Found" error for Azure BlobStorage and AWS S3 bindings
4 participants