Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

secret store: AWS connection validation for parameter store and secrets manager #3301

Merged
merged 12 commits into from Jan 16, 2024

Conversation

elena-kolevska
Copy link
Contributor

@elena-kolevska elena-kolevska commented Jan 3, 2024

Description

This PR adds AWS connection validation on dapr init for:

  • Secret Store: parameter store
  • Secret Store: secrets manager

Issue reference

#3190

Checklist

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation - N/A

Signed-off-by: Elena Kolevska <elena@kolevska.com>
Signed-off-by: Elena Kolevska <elena@kolevska.com>
Signed-off-by: Elena Kolevska <elena@kolevska.com>
Signed-off-by: Elena Kolevska <elena@kolevska.com>
Signed-off-by: Elena Kolevska <elena@kolevska.com>
Signed-off-by: Elena Kolevska <elena@kolevska.com>
…omplains against using math/rand

Signed-off-by: Elena Kolevska <elena@kolevska.com>
@elena-kolevska elena-kolevska changed the title AWS connection validation secret store: AWS connection validation for parameter store and secrets manager Jan 8, 2024
elena-kolevska and others added 2 commits January 8, 2024 11:53
Signed-off-by: Elena Kolevska <elena@kolevska.com>
@elena-kolevska elena-kolevska marked this pull request as ready for review January 8, 2024 11:54
@elena-kolevska elena-kolevska requested review from a team as code owners January 8, 2024 11:54
elena-kolevska and others added 3 commits January 8, 2024 13:51
Signed-off-by: Elena Kolevska <elena@kolevska.com>
Signed-off-by: ItalyPaleAle <43508+ItalyPaleAle@users.noreply.github.com>
@ItalyPaleAle ItalyPaleAle added this to the v1.13 milestone Jan 16, 2024
@ItalyPaleAle ItalyPaleAle added this pull request to the merge queue Jan 16, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 16, 2024
@ItalyPaleAle ItalyPaleAle merged commit 353447c into dapr:main Jan 16, 2024
88 checks passed
@elena-kolevska
Copy link
Contributor Author

Thanks @ItalyPaleAle :)

toneill818 pushed a commit to toneill818/components-contrib that referenced this pull request Jan 22, 2024
…ts manager (dapr#3301)

Signed-off-by: Elena Kolevska <elena@kolevska.com>
Signed-off-by: ItalyPaleAle <43508+ItalyPaleAle@users.noreply.github.com>
Co-authored-by: Alessandro (Ale) Segala <43508+ItalyPaleAle@users.noreply.github.com>
Signed-off-by: Alessandro (Ale) Segala <43508+ItalyPaleAle@users.noreply.github.com>
Signed-off-by: Thomas O'Neill <toneill@new-innov.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants