Add ExecuteInTransaction method for db.SQL #3309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A similar method already existed for Postgres, and this adds it for the other databases that use database/sql (MySQL, SQLite, SQL Server). Also fixes a bug in the SQL state store cleanup, where a transaction was started for no reason. Signed-off-by: ItalyPaleAle <43508+ItalyPaleAle@users.noreply.github.com>
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
toneill818
pushed a commit
to toneill818/components-contrib
that referenced
this pull request
Jan 22, 2024
Signed-off-by: ItalyPaleAle <43508+ItalyPaleAle@users.noreply.github.com> Signed-off-by: Thomas O'Neill <toneill@new-innov.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A similar method already existed for Postgres, and this adds it for the other databases that use database/sql (MySQL, SQLite, SQL Server).
Also fixes a bug in the SQL state store cleanup, where a transaction was started for no reason.
Doesn't add new features, just a small refactoring