Fixups from #3324 #3419
Merged
Fixups from #3324 #3419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes some bugs and other issues, including unnecessary metadata options and uneven info in `metadata.yaml` files, introduced in #3324 Signed-off-by: ItalyPaleAle <43508+ItalyPaleAle@users.noreply.github.com>
berndverst
approved these changes
May 21, 2024
|
FYI @sicoyle |
|
reviewing rn. Thanks for the tag here :) |
sicoyle
approved these changes
May 21, 2024
Comment on lines
+54
to
+58
| The connection string for the PostgreSQL database | ||
| This must contain the user, which corresponds to the name of the user created inside PostgreSQL that maps to the AWS IAM policy. This connection string should not contain any password. Note that the database name field is denoted by dbname with AWS. | ||
| example: | | ||
| "host=mydb.postgres.database.aws.com user=myapplication port=5432 dbname=dapr_test sslmode=require" | ||
| type: string |
There was a problem hiding this comment.
Suggested change
| The connection string for the PostgreSQL database | |
| This must contain the user, which corresponds to the name of the user created inside PostgreSQL that maps to the AWS IAM policy. This connection string should not contain any password. Note that the database name field is denoted by dbname with AWS. | |
| example: | | |
| "host=mydb.postgres.database.aws.com user=myapplication port=5432 dbname=dapr_test sslmode=require" | |
| type: string | |
| The connection string for the PostgreSQL database. | |
| This must contain the user, which corresponds to the name of the user created inside PostgreSQL that maps to the AWS IAM policy. This connection string should not contain any password. Note that the database name field is denoted by dbname with AWS. | |
| example: | | |
| "host=mydb.postgres.database.aws.com user=myapplication port=5432 dbname=dapr_test sslmode=require" | |
| type: string |
There was a problem hiding this comment.
Thanks. Note that this section was in the metadata.yaml for 2 of the 4 components already, but was missing on 2
Comment on lines
+44
to
+47
| The connection string for the PostgreSQL database | ||
| This must contain the user, which corresponds to the name of the user created inside PostgreSQL that maps to the AWS IAM policy. This connection string should not contain any password. Note that the database name field is denoted by dbname with AWS. | ||
| example: | | ||
| "host=mydb.postgres.database.aws.com user=myapplication port=5432 dbname=dapr_test sslmode=require" |
There was a problem hiding this comment.
Suggested change
| The connection string for the PostgreSQL database | |
| This must contain the user, which corresponds to the name of the user created inside PostgreSQL that maps to the AWS IAM policy. This connection string should not contain any password. Note that the database name field is denoted by dbname with AWS. | |
| example: | | |
| "host=mydb.postgres.database.aws.com user=myapplication port=5432 dbname=dapr_test sslmode=require" | |
| The connection string for the PostgreSQL database. | |
| This must contain the user, which corresponds to the name of the user created inside PostgreSQL that maps to the AWS IAM policy. This connection string should not contain any password. Note that the database name field is denoted by dbname with AWS. | |
| example: | | |
| "host=mydb.postgres.database.aws.com user=myapplication port=5432 dbname=dapr_test sslmode=require" |
|
@holopin-bot @ItalyPaleAle Enjoy the Dapr components badge! |
|
Congratulations @ItalyPaleAle, you just earned a badge! Here it is: https://holopin.io/claim/clxj3sppo29590dlgav7fwh6v This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes some bugs and other issues, including unnecessary metadata options and uneven info in
metadata.yamlfiles, introduced in #3324