-
Notifications
You must be signed in to change notification settings - Fork 468
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: runs checkout first and bump setup-go to v5 #3434
Conversation
Signed-off-by: mikeee <hey@mike.ee>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a good change to allow different go versions in different branches.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ironically this breaks unit tests - can you take a look?
@berndverst Just had a quick look, the workflow that is failing isn't modified in any way by this PR. Is it perhaps more a flaky log assertion/comparison that a rerun could yield a successful test? |
Signed-off-by: mikeee <hey@mike.ee>
Just triggered with an empty commit and appears to be passing 👌 https://github.com/dapr/components-contrib/actions/runs/9383880391/job/25838484450 |
Signed-off-by: mikeee <hey@mike.ee>
Latest commit introduces a lot of changes to resolve the linting issues |
Appears usurped, closing |
Description
#3319 introduced a setup step referencing a
go.mod
file to retrieve the go version. The repo needs to be checked out prior.This should fix the automatic releases after tag
Also lint fixes for: #3436
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #N/A
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: