Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: runs checkout first and bump setup-go to v5 #3434

Closed
wants to merge 6 commits into from

Conversation

mikeee
Copy link
Member

@mikeee mikeee commented Jun 1, 2024

Description

#3319 introduced a setup step referencing a go.mod file to retrieve the go version. The repo needs to be checked out prior.
This should fix the automatic releases after tag

Also lint fixes for: #3436

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #N/A

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation / Created issue in the https://github.com/dapr/docs/ repo: dapr/docs#[issue number]

@mikeee mikeee requested review from a team as code owners June 1, 2024 19:48
Signed-off-by: mikeee <hey@mike.ee>
Copy link
Member

@berndverst berndverst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good change to allow different go versions in different branches.

Copy link
Member

@berndverst berndverst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ironically this breaks unit tests - can you take a look?

@mikeee
Copy link
Member Author

mikeee commented Jun 4, 2024

Ironically this breaks unit tests - can you take a look?

@berndverst Just had a quick look, the workflow that is failing isn't modified in any way by this PR. Is it perhaps more a flaky log assertion/comparison that a rerun could yield a successful test?

Signed-off-by: mikeee <hey@mike.ee>
@mikeee
Copy link
Member Author

mikeee commented Jun 5, 2024

Just triggered with an empty commit and appears to be passing 👌

https://github.com/dapr/components-contrib/actions/runs/9383880391/job/25838484450

@mikeee mikeee requested a review from berndverst June 5, 2024 12:44
@mikeee
Copy link
Member Author

mikeee commented Jun 5, 2024

Latest commit introduces a lot of changes to resolve the linting issues

@mikeee
Copy link
Member Author

mikeee commented Jun 12, 2024

Appears usurped, closing

@mikeee mikeee closed this Jun 12, 2024
@mikeee mikeee deleted the fix-workflow branch June 12, 2024 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants