build: fix github wf to generate metadata bundle #3435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Samantha Coyle <sam@diagrid.io>
JoshVanL
approved these changes
Jun 4, 2024
yaron2
previously approved these changes
Jun 4, 2024
|
ready for merge pls :) |
Signed-off-by: Bernd Verst <github@bernd.dev>
berndverst
approved these changes
Jun 6, 2024
|
@holopin-bot @sicoyle Enjoy the Dapr components badge! |
|
Congratulations @sicoyle, you just earned a badge! Here it is: https://holopin.io/claim/clxj3xkgg42690dlg0plcjvr9 This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If we leave the workflow definition file as is, then it will not work. It will err with
The specified go version file at: go.mod does not exist. This is because the workflow steps set up Go referencing a go mod file before actually downloading the repo code that contains the go mod file that the precursor step needs. This PR fixes that issue, and bumps setup-go versions.Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #[issue number]
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: