Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix workflow stable component cert - bindings.rabbitmq #3454

Merged
merged 2 commits into from
Jun 21, 2024

Conversation

mikeee
Copy link
Member

@mikeee mikeee commented Jun 20, 2024

Description

Create a missing component spec - ensuring that the sidecar continues running after component failure.

Issue reference

Does not fully close the issue but arose from/is tracked by #3449

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation / Created issue in the https://github.com/dapr/docs/ repo: dapr/docs#[issue number]

Successful run: https://github.com/dapr/components-contrib/actions/runs/9604165214

Latest merge from main was blocked by a dockerhub registry outage

@mikeee mikeee changed the title tests: define exclusive rabbitmq spec with ignoreErrors=true fix workflow stable component cert - bindings.rabbitmq Jun 20, 2024
@mikeee mikeee marked this pull request as ready for review June 20, 2024 20:54
@mikeee mikeee requested review from a team as code owners June 20, 2024 20:54
@ItalyPaleAle ItalyPaleAle merged commit 8414210 into dapr:main Jun 21, 2024
64 of 91 checks passed
@mikeee mikeee deleted the cert-bindings-rabbitmq branch June 21, 2024 18:16
@berndverst berndverst added this to the v1.14 milestone Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants