Specify namespace for helm 3 uninstall (#966)

* Fix helm3 uninstall option * fix makefile
dapr · Jan 27, 2020 · c8ae917 · c8ae917
1 parent a76b809
commit c8ae917
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/tests/dapr_tests.mk b/tests/dapr_tests.mk
@@ -100,5 +100,5 @@ setup-test-components:
 	$(KUBECTL) get components --namespace $(DAPR_TEST_NAMESPACE)
 
 # Clean up test environment
-clean-test-env: $(HOME)/.helm
+clean-test-env:
 	./tests/test-infra/clean_up.sh $(DAPR_TEST_NAMESPACE)
diff --git a/tests/test-infra/clean_up.sh b/tests/test-infra/clean_up.sh
@@ -7,10 +7,11 @@
 
 [ -z "$1" ] && echo "Namespace must be specified" && exit 0
 
-installed_apps=$(helm list -q)
+installed_apps=$(helm list -q -n $1)
+echo $installed_apps
 
 for app in $installed_apps; do
-    helm delete --purge $app
+    helm uninstall $app -n $1
 done
 
 echo "Trying to delete namespace..."