-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Revert ]Merge Actor activation and first method/reminder call to user service. #219
Comments
I generally support that notion, however I don't like the use of headers unless absolutely critical. |
A decision has to be made by SDK/UserCode, so a flag indicating ActivateBeforeInvocation needs to be passed from Actions runtime. It can either be a query parameter or a header. |
query param then. |
We need to open an issue for this in the spec repo to update the API endpoint, but only for the September iteration. |
Corresponding spec issue: https://github.com/actionscore/spec/issues/10 |
@amanbha I have some bandwidth to complete this for the current iteration, but that would involve a change in the SDK as well. Do you think you can make it or should we leave this item for the next iteration? |
@yaron2 Lets do it in next iteration. |
Actions runtime will not be able to distinguish between ActorActivation failure and method invocation failure. So it will try to activate the actor again even if the ActorActivation succeeded and only method invocation failed. Instead Actions runtime will revert the change to merge the calls made in this PR# #280 |
Currently 2 calls happen into user code when a method/reminder is invoked on an inactive actor:
Instead just invoke the ActorMethod and provide an optional header (or query param) to indicate activation before method invocation. SDK/User code can look at this header(query param) to determine whether it needs to be activated.
The text was updated successfully, but these errors were encountered: