Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scheduling of workflows #7354

Closed
shivamkm07 opened this issue Jan 9, 2024 · 4 comments
Closed

Scheduling of workflows #7354

shivamkm07 opened this issue Jan 9, 2024 · 4 comments
Labels
kind/enhancement stale Issues and PRs without response

Comments

@shivamkm07
Copy link
Contributor

In what area(s)?

/area runtime

/area operator

/area placement

/area docs

/area test-and-release

Describe the feature

Dapr workflows should support scheduling of workflows at a later time.

As per implementation, it seems that users are expected to pass time as metadata while sending the request with startTime set as dapr.workflow.start_time:

if startTimeRFC3339, ok := req.Options["dapr.workflow.start_time"]; ok {

However, this is not respected and carried at all places.

  1. It is not being set as part of the http request:
    return UniversalHTTPHandler(
  2. DTF-Go(which dapr uses for orchestration management) doesn't forward the scheduled time to backend: Scheduling of workflows microsoft/durabletask-go#57
  3. Once the above issue is resolved, required delay needs to be added while creating the workflow reminder to actually schedule the workflow. Currently it schedules immediately even if scheduledTime is passed while creating the workflow:
    if _, err := wf.createReliableReminder(ctx, actorID, "start", nil, 0); err != nil {

Release Note

RELEASE NOTE:

@msfussell
Copy link
Member

@shivamkm07 Before merging this PR, please create a Docs PR for the workflow changes

@shivamkm07
Copy link
Contributor Author

@shivamkm07 Before merging this PR, please create a Docs PR for the workflow changes

This PR mostly won't be going in 1.13. For other PR that has been merged, tracking issue was created: dapr/docs#3949. Will create the PR soon.

@dapr-bot
Copy link
Collaborator

This issue has been automatically marked as stale because it has not had activity in the last 60 days. It will be closed in the next 7 days unless it is tagged (pinned, good first issue, help wanted or triaged/resolved) or other activity occurs. Thank you for your contributions.

@dapr-bot dapr-bot added the stale Issues and PRs without response label Mar 24, 2024
@dapr-bot
Copy link
Collaborator

This issue has been automatically closed because it has not had activity in the last 67 days. If this issue is still valid, please ping a maintainer and ask them to label it as pinned, good first issue, help wanted or triaged/resolved. Thank you for your contributions.

@dapr-bot dapr-bot closed this as not planned Won't fix, can't repro, duplicate, stale Mar 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement stale Issues and PRs without response
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants