Workflow execution and scheduling latency #7370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: prateek041 <prateeksingh9741@gmail.com>
- Operations - Reminders - Execution Signed-off-by: prateek041 <prateeksingh9741@gmail.com>
Signed-off-by: prateek041 <prateeksingh9741@gmail.com>
- Create Workflow - Get Workflow - Purge Workflow - Add Events Signed-off-by: prateek041 <prateeksingh9741@gmail.com>
Signed-off-by: prateek041 <prateeksingh9741@gmail.com>
executions. Signed-off-by: prateek041 <prateeksingh9741@gmail.com>
Signed-off-by: prateek041 <prateeksingh9741@gmail.com>
Signed-off-by: prateek041 <prateeksingh9741@gmail.com>
Signed-off-by: prateek041 <prateeksingh9741@gmail.com>
Signed-off-by: prateek041 <prateeksingh9741@gmail.com>
Signed-off-by: prateek041 <prateeksingh9741@gmail.com>
Signed-off-by: prateek041 <prateeksingh9741@gmail.com>
Signed-off-by: prateek041 <prateeksingh9741@gmail.com>
Signed-off-by: prateek041 <prateeksingh9741@gmail.com>
Signed-off-by: prateek041 <prateeksingh9741@gmail.com>
Signed-off-by: prateek041 <prateeksingh9741@gmail.com>
Signed-off-by: prateek041 <prateeksingh9741@gmail.com>
Signed-off-by: prateek041 <prateeksingh9741@gmail.com>
Signed-off-by: prateek041 <prateeksingh9741@gmail.com>
Signed-off-by: prateek041 <prateeksingh9741@gmail.com>
Signed-off-by: prateek041 <prateeksingh9741@gmail.com>
Signed-off-by: Shivam Kumar <shivamkm07@gmail.com>
Signed-off-by: Shivam Kumar <shivamkm07@gmail.com>
Signed-off-by: Shivam Kumar <shivamkm07@gmail.com>
Signed-off-by: MD Ashique <noorani.ashique5@gmail.com>
Signed-off-by: MD Ashique <noorani.ashique5@gmail.com>
Signed-off-by: MD Ashique <noorani.ashique5@gmail.com>
Signed-off-by: MD Ashique <noorani.ashique5@gmail.com>
Co-authored-by: Alessandro (Ale) Segala <43508+ItalyPaleAle@users.noreply.github.com> Signed-off-by: MD Ashique <noorani.ashique5@gmail.com>
…ssage Signed-off-by: MD Ashique <noorani.ashique5@gmail.com>
…ssage Signed-off-by: MD Ashique <noorani.ashique5@gmail.com>
…ssage Signed-off-by: MD Ashique <noorani.ashique5@gmail.com>
Signed-off-by: MD Ashique <noorani.ashique5@gmail.com>
…ssage Signed-off-by: MD Ashique <noorani.ashique5@gmail.com>
Signed-off-by: MD Ashique <noorani.ashique5@gmail.com>
Signed-off-by: MD Ashique <noorani.ashique5@gmail.com>
|
LGTM. Just one comment - We can possibly add an integration test for execution latency here: e.g. a workflow with a sleep(5 seconds) should have executionLatency > 5sec (We can actually add for scheduling latency too like for workflow with ScheduledStartTimeStamp set to T, SchedulingLatency > T - currentTime but this test won't pass since scheduling doesn't work correctly as of now: #7354)
|
Signed-off-by: MD Ashique <noorani.ashique5@gmail.com>
artursouza
approved these changes
Jan 29, 2024
mukundansundar
approved these changes
Jan 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We are adding metrics to measure Dapr workflow execution and scheduling latency. The calculation strategy for these metrics is defined here.
This PR should be merged after dtf-go pr is merged.
Issue reference
Please reference the issue this PR will close: #7109
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: