Do not type convert data to string for transaction API. #2010
Conversation
|
Code still needs the change from components contrib to be merged first and ref updated in this repo. |
|
/ok-to-test |
|
Found the available test cluster - dapr-aks-e2e-07 for linux. Please wait until test is done. |
|
Found the available test cluster - dapr-aks-e2e-08 for windows. Please wait until test is done. |
|
End-to-end tests failed on linux. |
|
End-to-end tests cancelled on windows. |
mukundansundar
force-pushed
the
fix-serde-transsaction-api
branch
from
8e80114
to
2ee1a29
Compare
|
Need to run the E2E tests only after the new components contrib is merged in. Will be updating this PR once that code is merged in. |
|
/ok-to-test |
|
Found the available test cluster - dapr-aks-e2e-08 for linux. Please wait until test is done. |
|
End-to-end tests cancelled on linux. |
|
/ok-to-test |
|
Found the available test cluster - dapr-aks-e2e-05 for linux. Please wait until test is done. |
|
End-to-end tests cancelled on linux. |
|
/ok-to-test |
|
Found the available test cluster - dapr-aks-e2e-05 for linux. Please wait until test is done. |
|
Found the available test cluster - dapr-aks-e2e-06 for windows. Please wait until test is done. |
|
Congrats! All end-to-end tests have passed on linux. Thanks for your contribution! |
mukundansundar
requested review from
youngbupark,
artursouza,
yaron2 and
tcnghia
|
Congrats! All end-to-end tests have passed on windows. Thanks for your contribution! |
Description
Found an issue for Transaction API via Java Integration Tests.
When the state is stored via an upsert call made and the got back via the normal getState API call, it can be observed that there is an extra Json Marshal happening in the code.
Example:
data: "\"{\\\"propertyA\\\":\\\"data in property A\\\",\\\"propertyB\\\":\\\"data in property B\\\"}\""Instead of
data: "{\"propertyA\":\"data in property A\",\"propertyB\":\"data in property B\"}"The second output is what we have when we have a normal save and get state call done via Dapr.
The code change here, checks if the incoming request value is a byte array or not and then properly serializes the value.
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #2016
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: