-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make cors middleware optional + tests #2285
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2285 +/- ##
==========================================
+ Coverage 48.08% 48.23% +0.14%
==========================================
Files 70 70
Lines 6143 6145 +2
==========================================
+ Hits 2954 2964 +10
+ Misses 2931 2923 -8
Partials 258 258
Continue to review full report at Codecov.
|
is there a reason why we make cors middleware ? is this for testing? |
It's a feature we had from the very beginning, presumably to make sure that the Dapr API can only be accessed from certain origins. (helpful in the case where you expose the Dapr API publicly). |
From the code I am reading, we only control New cors package includes only one constant so I was wonder if we need this change. Also do we plan to support the other CORS headers ? |
The change just refactored the location of the const, didn't add a new one.
I don't know, maybe. we need to probably make CORS more visible to users and get feedback. |
This PR does the following:
Release Note
RELEASE NOTE: Changed Cors middleware to optional + added tests