Upgrade dependencies, remove fmt.sprintf from hotpath #2287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youngbupark
previously approved these changes
Oct 19, 2020
|
Wow, unit tests prevented a fail. |
Codecov Report
@@ Coverage Diff @@
## master #2287 +/- ##
=======================================
Coverage 48.32% 48.32%
=======================================
Files 70 70
Lines 6146 6146
=======================================
Hits 2970 2970
Misses 2920 2920
Partials 256 256
Continue to review full report at Codecov.
|
youngbupark
approved these changes
Oct 19, 2020
wcs1only
pushed a commit
to wcs1only/dapr
that referenced
this pull request
Oct 22, 2020
* upgrade dependencies, remove fmt.sprintf from hotpath * remove commented code * fix test
vinayada1
pushed a commit
to vinayada1/dapr
that referenced
this pull request
Nov 2, 2020
* upgrade dependencies, remove fmt.sprintf from hotpath * remove commented code * fix test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR upgrades several key packages used by Dapr and replaces
fmt.Sprintffrom a method in service invocation hot path, as profiling had revealed it can be improved by concatenation.Release Note
RELEASE NOTE: Improved performance by removing
fmt.Sprintffrom hot path for service invocation