fix(actors): timer ticker bug #2673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2673 +/- ##
==========================================
+ Coverage 58.09% 58.14% +0.05%
==========================================
Files 82 82
Lines 7385 7390 +5
==========================================
+ Hits 4290 4297 +7
+ Misses 2802 2799 -3
- Partials 293 294 +1
Continue to review full report at Codecov.
|
|
@vinayada1 can you review this? |
vinayada1
reviewed
Jan 25, 2021
| @@ -828,6 +828,10 @@ func (a *actorsRuntime) CreateReminder(ctx context.Context, req *CreateReminderR | |||
| } | |||
|
|
|||
| func (a *actorsRuntime) CreateTimer(ctx context.Context, req *CreateTimerRequest) error { | |||
| var ( | |||
| err error | |||
There was a problem hiding this comment.
Could you please add a UT?
|
@1046102779 we will merge this as is, thanks a lot for this fix. please find the time to add a unit test in a separate PR. |
artursouza
approved these changes
Jan 26, 2021
4 tasks
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The timer task needs to wait for the execution of the first dueTime's task to start the period's timer