Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update contrib to get fix on KV getBulkSecret API. #2713

Merged
merged 1 commit into from Jan 25, 2021

Conversation

artursouza
Copy link
Member

Description

Update contrib to get fix on KV getBulkSecret API.

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: N/A

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

@artursouza
Copy link
Member Author

/ok-to-test

@dapr-bot
Copy link
Collaborator

Found the available test cluster - dapr-aks-e2e-06 for linux. Please check the build status.

@dapr-bot
Copy link
Collaborator

Found the available test cluster - dapr-aks-e2e-05 for windows. Please check the build status.

@yaron2
Copy link
Member

yaron2 commented Jan 25, 2021

Did you run go mod tidy?

@codecov
Copy link

codecov bot commented Jan 25, 2021

Codecov Report

Merging #2713 (093a026) into master (ea33090) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2713      +/-   ##
==========================================
+ Coverage   58.01%   58.04%   +0.02%     
==========================================
  Files          82       82              
  Lines        7367     7367              
==========================================
+ Hits         4274     4276       +2     
+ Misses       2799     2797       -2     
  Partials      294      294              
Impacted Files Coverage Δ
pkg/placement/membership.go 55.31% <0.00%> (+1.41%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ea33090...093a026. Read the comment docs.

@artursouza
Copy link
Member Author

/ok-to-test

@dapr-bot
Copy link
Collaborator

Found the available test cluster - dapr-aks-e2e-07 for linux. Please check the build status.

@dapr-bot
Copy link
Collaborator

Found the available test cluster - dapr-aks-e2e-08 for windows. Please check the build status.

@yaron2 yaron2 merged commit f4327d9 into dapr:master Jan 25, 2021
@dapr-bot
Copy link
Collaborator

Congrats! All end-to-end tests have passed on linux. Thanks for your contribution!

@dapr-bot
Copy link
Collaborator

Congrats! All end-to-end tests have passed on windows. Thanks for your contribution!

@dapr-bot
Copy link
Collaborator

Congrats! All end-to-end tests have passed on linux. Thanks for your contribution!

@dapr-bot
Copy link
Collaborator

Congrats! All end-to-end tests have passed on windows. Thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants