Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix spelling of separator #2913

Merged
merged 3 commits into from Mar 22, 2021
Merged

Fix spelling of separator #2913

merged 3 commits into from Mar 22, 2021

Conversation

dinggh
Copy link
Contributor

@dinggh dinggh commented Mar 11, 2021

Description

spelling separator

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #2912

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

@ghost
Copy link

ghost commented Mar 11, 2021

CLA assistant check
All CLA requirements met.

@dinggh dinggh changed the title Fix spelling of separator(#2912) Fix spelling of separator Mar 11, 2021
@codecov
Copy link

codecov bot commented Mar 11, 2021

Codecov Report

Merging #2913 (58840b5) into master (0340225) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2913   +/-   ##
=======================================
  Coverage   58.96%   58.96%           
=======================================
  Files          87       87           
  Lines        7666     7666           
=======================================
  Hits         4520     4520           
  Misses       2834     2834           
  Partials      312      312           
Impacted Files Coverage Δ
pkg/scopes/scopes.go 93.10% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0340225...58840b5. Read the comment docs.

@yaron2
Copy link
Member

yaron2 commented Mar 19, 2021

@dinggh you need to complete the CLA signing so we can accept this contribution.

@dinggh
Copy link
Contributor Author

dinggh commented Mar 20, 2021

@dinggh you need to complete the CLA signing so we can accept this contribution.

done

@yaron2 yaron2 added this to the v1.1 milestone Mar 21, 2021
@yaron2 yaron2 merged commit 27093e0 into dapr:master Mar 22, 2021
daheige pushed a commit to daheige/dapr that referenced this pull request Apr 13, 2021
Co-authored-by: wenjing.dgh <wenjing.dgh@taobao.com>
Co-authored-by: Yaron Schneider <yaronsc@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix spelling of separator in scopes package
4 participants